[v3,7/8] i2c: designware: Don't resume device in the ->complete() callback

Message ID 1504018610-10822-8-git-send-email-ulf.hansson@linaro.org
State New
Headers show
  • PM / ACPI / i2c: Deploy runtime PM centric path for system sleep
Related show

Commit Message

Ulf Hansson Aug. 29, 2017, 2:56 p.m.
In case the PM core is able to use the direct_complete path during system
sleep for the i2c device, the device is runtime resumed in the ->complete()
callback. For ACPI platforms this is needed to synchronize the power state
of the device, while for non-ACPI platforms this is a waste.

To better deal with this, let's drop the ->complete() callback from the
i2c-dw-plat driver altogether, thus avoiding the runtime resume of the

This change still plays well for the ACPI case, because the ACPI PM
domain's ->complete() callback, assigned to acpi_subsys_complete(), already
deals with runtime resuming the device in case it's needed.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>


Changes in v3:
	- None.

 drivers/i2c/busses/i2c-designware-platdrv.c | 8 --------
 1 file changed, 8 deletions(-)



diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 57248bc..38121c9 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -417,15 +417,8 @@  static int dw_i2c_plat_prepare(struct device *dev)
 	return pm_runtime_suspended(dev);
-static void dw_i2c_plat_complete(struct device *dev)
-	if (dev->power.direct_complete)
-		pm_request_resume(dev);
 #define dw_i2c_plat_prepare	NULL
-#define dw_i2c_plat_complete	NULL
 #ifdef CONFIG_PM
@@ -461,7 +454,6 @@  static int dw_i2c_plat_suspend(struct device *dev)
 static const struct dev_pm_ops dw_i2c_dev_pm_ops = {
 	.prepare = dw_i2c_plat_prepare,
-	.complete = dw_i2c_plat_complete,
 	SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume)