net: ti: cpsw-common: dont print error if ti_cm_get_macid() fails

Message ID 423afc6874d8911615c4df941957067aebfc09dd.1504080198.git.nsekhar@ti.com
State New
Headers show
Series
  • net: ti: cpsw-common: dont print error if ti_cm_get_macid() fails
Related show

Commit Message

Sekhar Nori Aug. 30, 2017, 8:07 a.m.
It is quite common for ti_cm_get_macid() to fail on some of the
platforms it is invoked on. They include any platform where
mac address is not part of SoC register space.

On these platforms, mac address is read and populated in
device-tree by bootloader. An example is TI DA850.

Downgrade the severity of message to "information", so it does
not spam logs when 'quiet' boot is desired.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>

---
 drivers/net/ethernet/ti/cpsw-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Aug. 30, 2017, 5:09 p.m. | #1
From: Sekhar Nori <nsekhar@ti.com>

Date: Wed, 30 Aug 2017 13:37:13 +0530

> It is quite common for ti_cm_get_macid() to fail on some of the

> platforms it is invoked on. They include any platform where

> mac address is not part of SoC register space.

> 

> On these platforms, mac address is read and populated in

> device-tree by bootloader. An example is TI DA850.

> 

> Downgrade the severity of message to "information", so it does

> not spam logs when 'quiet' boot is desired.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 56ba411421f0..38d1cc557c11 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -96,7 +96,7 @@  int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
 	if (of_machine_is_compatible("ti,dra7"))
 		return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr);
 
-	dev_err(dev, "incompatible machine/device type for reading mac address\n");
+	dev_info(dev, "incompatible machine/device type for reading mac address\n");
 	return -ENOENT;
 }
 EXPORT_SYMBOL_GPL(ti_cm_get_macid);