From patchwork Wed Aug 30 08:47:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 111291 Delivered-To: patch@linaro.org Received: by 10.140.95.112 with SMTP id h103csp597205qge; Wed, 30 Aug 2017 01:51:02 -0700 (PDT) X-Received: by 10.99.96.21 with SMTP id u21mr810232pgb.400.1504083061928; Wed, 30 Aug 2017 01:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504083061; cv=none; d=google.com; s=arc-20160816; b=tpgQZDjJbPWpNYEIEgiq19K4MDk/8arhs+eE45velkDcfb0KVRFgj2VFEgxQXrmgTX ffRAUFmsO0SaW14eEqJiIaAIdBbmPv1hm2D3eWFM89Cr1+zVmG/S8ve6yrQWC70r8ubf jbYx7EyK0lN0Hbl5ofrxXxxqL3CZ24OG67kwZMc5hcNeKyApepzsB6NOVJO9lVyI7iNo ust8lO3vunfLtlAF0NjX1xzt6awTSXZTXCn40Q54CVdp/qJ7d4cvnr30Falkz9KZlhyh XeZwRGdPmt/oGW+k9Yvb5lmQXL9Bc0Bvl/5kInDAfj0NMhl/cYSuDLrHkQSywfF8WBxl /8mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=FiACXre4j1zDHJFAozRZ8XVINlP9M64l5RYa3Gl2lig=; b=Xu9xNdV4jZX9S2DjDVn9vRFqInOzFeU9pdkpuV9w+E0OFAjmo9NZXQxC6y2MwIsvqM WNuApQ00dBkS7vKZXyYXuwBiEwTWXUP78v2CVYze4qMQZiFLmzn21JqovhQs6um9Ukz4 Ymn0WdOk9Xh1/WTe3FNiKfNLN8R+mDKqrrY60UZqkb20688LrzWXzkSb2Z0B7yP2R3BN A2F3XO6pdehSdYayCGEN2j9c714YIGj4SxKKIxr+0psZfGb6k3JLygC5WrBMvgXs796r //xEGXWTyModkuPlquw0Rr5NtKpXdv0FxokZlwX98vw/yjqX9j23HSekrO/aQ2N+hTxs +HQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jEIcLZUD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si4121985pln.393.2017.08.30.01.51.01; Wed, 30 Aug 2017 01:51:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jEIcLZUD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbdH3Iu7 (ORCPT + 26 others); Wed, 30 Aug 2017 04:50:59 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:34280 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbdH3Isx (ORCPT ); Wed, 30 Aug 2017 04:48:53 -0400 Received: by mail-wr0-f176.google.com with SMTP id z91so16540471wrc.1 for ; Wed, 30 Aug 2017 01:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FiACXre4j1zDHJFAozRZ8XVINlP9M64l5RYa3Gl2lig=; b=jEIcLZUDuoiZ+g3IugB23GGhaPNlb319S54AIaPvtwiICYsWUg+eRkCsZQwhgaW7nI STZb6aNf8EJ8si/0nP61cy+0RBDVnL+NlN56d8uPqM7pb8xmO8eAXmDv8Qlga6F6OslS PrNsyKeM6H7jNJ/wT/meqhE9JpZ7Z0K1pJJFM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FiACXre4j1zDHJFAozRZ8XVINlP9M64l5RYa3Gl2lig=; b=IY/feSCOMR0BwiIykYhZf36HDZ6Tn1joYqv3/5As9TrO1zu4NHSKP+MnP4yV3kpMiT pe+Rrb21sVmM/w6bgmPfMxSkPRQiSaFQ45bbM81jCG+nf2FYurLYug3os1HGmtII7pPS JjLeRfMF8zB4JnR3ZgnWJpdYJuSzDFUNQjpWpCa9+ygWGcKubSiPL5QbyvnavaZu1Suv Gq4f1DOLtbip5yJt/bIhGefjyAny1dNrOftK4j1qH2b2ub3C+kvle0zWZVkw25qTflQX wxMIjF9vMIJtm/qjUUkROa9E+CiDDviuneE+EkoTm3ftN2ibcWgQF9l6osobIzCtENJ9 Js1A== X-Gm-Message-State: AHYfb5jucKxMRjDOQPxc/msP5EKxzbK+n5q3cMpSyS4y3Wr2ody61fg5 9li+RDAs3kItXUJ6 X-Received: by 10.223.154.73 with SMTP id z67mr547184wrb.136.1504082932355; Wed, 30 Aug 2017 01:48:52 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:b0b0:ba2b:b9fd:8a33]) by smtp.gmail.com with ESMTPSA id q24sm4032811wrc.26.2017.08.30.01.48.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Aug 2017 01:48:51 -0700 (PDT) From: Daniel Lezcano To: rui.zhang@intel.com, edubezval@gmail.com Cc: daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, kevin.wangtao@linaro.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org (open list) Subject: [PATCH 06/13] thermal/drivers/hisi: Remove pointless lock Date: Wed, 30 Aug 2017 10:47:30 +0200 Message-Id: <1504082857-21702-6-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504082857-21702-1-git-send-email-daniel.lezcano@linaro.org> References: <1504082857-21702-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The threaded interrupt inspect the sensors structure to look in the temp threshold field, but this field is read-only in all the code, except in the probe function before the threaded interrupt is set. In other words there is not race window in the threaded interrupt when reading the field value. Signed-off-by: Daniel Lezcano --- drivers/thermal/hisi_thermal.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.7.4 diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index 524310d..6f0dab1 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev) static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev) { struct hisi_thermal_data *data = dev; - struct hisi_thermal_sensor *sensor; - - mutex_lock(&data->thermal_lock); - sensor = &data->sensors; + struct hisi_thermal_sensor *sensor = &data->sensors; dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n", sensor->thres_temp); - mutex_unlock(&data->thermal_lock); thermal_zone_device_update(data->sensors.tzd, THERMAL_EVENT_UNSPECIFIED);