[edk2] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency

Message ID 20170830093012.22651-1-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • [edk2] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency
Related show

Commit Message

Ard Biesheuvel Aug. 30, 2017, 9:30 a.m.
This driver does not support on DmaLib, so don't declare it as a
dependency.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
 1 file changed, 1 deletion(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Aug. 30, 2017, 9:31 a.m. | #1
On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> This driver does not support on DmaLib, so don't declare it as a

> dependency.

>


-EGRAMMAR

Will fix before submitting

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf

> index 6719d0adcc87..0fc8bd88c6ce 100644

> --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf

> +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf

> @@ -37,7 +37,6 @@ [LibraryClasses]

>    ArmShellCmdRunAxfLib

>    BaseMemoryLib

>    DebugLib

> -  DmaLib

>    DxeServicesTableLib

>    IoLib

>    NonDiscoverableDeviceRegistrationLib

> --

> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Aug. 30, 2017, 9:33 a.m. | #2
On Wed, Aug 30, 2017 at 10:31:22AM +0100, Ard Biesheuvel wrote:
> On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> > This driver does not support on DmaLib, so don't declare it as a

> > dependency.

> >

> 

> -EGRAMMAR

> 

> Will fix before submitting


With that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>



> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> > ---

> >  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -

> >  1 file changed, 1 deletion(-)

> >

> > diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf

> > index 6719d0adcc87..0fc8bd88c6ce 100644

> > --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf

> > +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf

> > @@ -37,7 +37,6 @@ [LibraryClasses]

> >    ArmShellCmdRunAxfLib

> >    BaseMemoryLib

> >    DebugLib

> > -  DmaLib

> >    DxeServicesTableLib

> >    IoLib

> >    NonDiscoverableDeviceRegistrationLib

> > --

> > 2.11.0

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Aug. 30, 2017, 9:35 a.m. | #3
On 30 August 2017 at 10:33, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Aug 30, 2017 at 10:31:22AM +0100, Ard Biesheuvel wrote:

>> On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

>> > This driver does not support on DmaLib, so don't declare it as a

>> > dependency.

>> >

>>

>> -EGRAMMAR

>>

>> Will fix before submitting

>

> With that:

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Pushed as db6f08a0eae6

Thanks.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
index 6719d0adcc87..0fc8bd88c6ce 100644
--- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
+++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
@@ -37,7 +37,6 @@  [LibraryClasses]
   ArmShellCmdRunAxfLib
   BaseMemoryLib
   DebugLib
-  DmaLib
   DxeServicesTableLib
   IoLib
   NonDiscoverableDeviceRegistrationLib