[1/2] drm: bridge: Add bindings for TI THS8134

Message ID 20170901094038.4312-1-linus.walleij@linaro.org
State New
Headers show
Series
  • [1/2] drm: bridge: Add bindings for TI THS8134
Related show

Commit Message

Linus Walleij Sept. 1, 2017, 9:40 a.m.
This adds device tree bindings for the Texas Instruments
THS8134A and THS8134B VGA DACs by extending and renaming the
existing bindings for THS8135.

These DACs are used for the VGA outputs on the ARM reference
designs such as Integrator, Versatile and RealView.

Cc: devicetree@vger.kernel.org
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 .../display/bridge/{ti,ths8135.txt => ti,ths813x.txt}        | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
 rename Documentation/devicetree/bindings/display/bridge/{ti,ths8135.txt => ti,ths813x.txt} (73%)

-- 
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Sept. 12, 2017, 4:39 p.m. | #1
On Fri, Sep 01, 2017 at 11:40:37AM +0200, Linus Walleij wrote:
> This adds device tree bindings for the Texas Instruments

> THS8134A and THS8134B VGA DACs by extending and renaming the

> existing bindings for THS8135.

> 

> These DACs are used for the VGA outputs on the ARM reference

> designs such as Integrator, Versatile and RealView.

> 

> Cc: devicetree@vger.kernel.org

> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  .../display/bridge/{ti,ths8135.txt => ti,ths813x.txt}        | 12 ++++++++----

>  1 file changed, 8 insertions(+), 4 deletions(-)

>  rename Documentation/devicetree/bindings/display/bridge/{ti,ths8135.txt => ti,ths813x.txt} (73%)


Acked-by: Rob Herring <robh@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Sept. 13, 2017, 12:08 a.m. | #2
Hi Linus,

Thank you for the patch.

On Friday, 1 September 2017 12:40:37 EEST Linus Walleij wrote:
> This adds device tree bindings for the Texas Instruments

> THS8134A and THS8134B VGA DACs by extending and renaming the

> existing bindings for THS8135.

> 

> These DACs are used for the VGA outputs on the ARM reference

> designs such as Integrator, Versatile and RealView.

> 

> Cc: devicetree@vger.kernel.org

> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  .../display/bridge/{ti,ths8135.txt => ti,ths813x.txt}        | 12 ++++++---

>  1 file changed, 8 insertions(+), 4 deletions(-)

>  rename Documentation/devicetree/bindings/display/bridge/{ti,ths8135.txt =>

> ti,ths813x.txt} (73%)

> 

> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt

> b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt

> similarity index 73%

> rename from Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt

> rename to Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt

> index 6ec1a880ac18..608435f04796 100644

> --- a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt

> +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt

> @@ -1,11 +1,15 @@

> -THS8135 Video DAC

> ------------------

> +THS8134 and THS8135 Video DAC

> +-----------------------------

> 

> -This is the binding for Texas Instruments THS8135 Video DAC bridge.

> +This is the binding for Texas Instruments THS8134A, THS8134B and THS8135

> +Video DAC bridge.

> 

>  Required properties:

> 

> -- compatible: Must be "ti,ths8135"

> +- compatible: Must be one of

> +  "ti,ths8134a"

> +  "ti,ths8134b"

> +  "ti,ths8135"


As mentioned in the review of patch 2/2, would it make sense to also introduce 
a ti,ths813x compatible string ? I haven't checked the datasheets so the 
answer might very well be no.

>  Required nodes:



-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Oct. 16, 2017, 12:52 p.m. | #3
On Wed, Sep 13, 2017 at 2:08 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:

>> -- compatible: Must be "ti,ths8135"

>> +- compatible: Must be one of

>> +  "ti,ths8134a"

>> +  "ti,ths8134b"

>> +  "ti,ths8135"

>

> As mentioned in the review of patch 2/2, would it make sense to also introduce

> a ti,ths813x compatible string ? I haven't checked the datasheets so the

> answer might very well be no.


That should be fine, compatible-properties from the most specific to the
most generic should work just fine.

I'll respin with a ths813x compatible.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt
similarity index 73%
rename from Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt
rename to Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt
index 6ec1a880ac18..608435f04796 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt
+++ b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt
@@ -1,11 +1,15 @@ 
-THS8135 Video DAC
------------------
+THS8134 and THS8135 Video DAC
+-----------------------------
 
-This is the binding for Texas Instruments THS8135 Video DAC bridge.
+This is the binding for Texas Instruments THS8134A, THS8134B and THS8135
+Video DAC bridge.
 
 Required properties:
 
-- compatible: Must be "ti,ths8135"
+- compatible: Must be one of
+  "ti,ths8134a"
+  "ti,ths8134b"
+  "ti,ths8135"
 
 Required nodes: