From patchwork Fri Sep 1 13:08:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 111484 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp904814ybm; Fri, 1 Sep 2017 06:04:44 -0700 (PDT) X-Received: by 10.84.132.73 with SMTP id 67mr2328981ple.449.1504271084896; Fri, 01 Sep 2017 06:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504271084; cv=none; d=google.com; s=arc-20160816; b=EnqTeL1riy6Mbh/CtiBiKcA4yHs7S4OzEF8ln9ALnCI9nUDzCZRxuFXU/B1pqg1NoZ hYDiTz1cXkCjSGt195NQ9fe/Nm1XFRsaRpRTFdIK6OeI5m2satS/cEkwvVDPIprjuSkn pFEEudvcT/+S+uBLvSbsOGqh23oFp6bpjcJ6xjbJzlFtj8iMEDuP0xKP3mlTQc1f8jEw DQOjPNTYmA+uzSbyxy0NP0i0dNRr2liYedWQnuWbe5dSQ9CKqmTpPXprhFjEH01GQ358 PwAqKERhkhbtAIY2WAKT4XsIhzxjz/sPg1RlD7d/EjBjkRMYDsqCMx+RLmomZih/1wYE XR3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=b7fZ7h474qW1x5zS1I0I4AlZ8o9qW1IdRfaQS7qvI40=; b=rS6S1w7DIAjPDGT3UIWGNVU6UkH6Rxzxj3skhzfukDzTdER2hv/6GQSei+X1Wqa/1A rUX6/j7lSizz2Y22ebFhEX4i/0M0c5+h0ZjOxffY/rl1kMIa0UJ9IWXlq/R6qPk6TZsQ VNBUJLLse03PRx+usSbG5VTvI9uN8Lb7jAxmHcJG4r7//ZTeWV1me8cX8upbH0n/osZH cZ8jK4JOdqeEXmbabLeCi88tjdeSuBSt1ARUGoaub4Uz+rvaZuetB+0sYa7D8pF/rGF0 PoGE4m9YajZWdM+K+KsHePZrlMDcNjBchyjBvGLm6uHWfrQC6riKWSJqC7+eHlxB9L+F SCfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=yf1vdVv0; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id s23si111106pfe.16.2017.09.01.06.04.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Sep 2017 06:04:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=yf1vdVv0; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B955E21E2BE3E; Fri, 1 Sep 2017 06:01:48 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0CADF21D1E2E7 for ; Fri, 1 Sep 2017 06:01:47 -0700 (PDT) Received: by mail-lf0-x235.google.com with SMTP id a126so691969lfa.0 for ; Fri, 01 Sep 2017 06:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oHhmTu8pdge4mIH+mWlIXF4ZczpC53TcHkV+Jsz5sOg=; b=yf1vdVv0J9PRPdWdT7ukuB1OSjJHEJ+aAAyKy2Iws5j6zgw9EslK3T+yGkQ+ytk0V+ opyWP7y8d1om9ntY0aMNr6/mnWdNlRtrBIAt83qj/3d/loXEoQ/x91grP9L7gq2VNPZT zjWdf2MD+ELTnqChT/p/1tB0Ygih9/ikJVjXqpZqPDXw2etSny6umv7bJrEasWEZz4uq pUStJIIs9ONsNxfXYXlUBe5xrvyKEvf1Lkm20Ue/AgmshReMbRGUWgy/P1G/Wkf6R7W6 MNcq+qDK6CXxvVNYR3/fQLXGdmyTwls7X5COOlEsEWAX8I3FfRYDhqBuT3jHhCocZeJc 4oMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oHhmTu8pdge4mIH+mWlIXF4ZczpC53TcHkV+Jsz5sOg=; b=qw3kyYDSY7l98hsUzrAr0Svf4O47ubG7L/UzGN8/xU21vCljsTndEZ03nxdnwocRWf 3ymvtcDRHdVnCjT52DJsz4ShPq8930lVq45KrvgXPBaFJJPra7igCMqj28cVm69L7f6W Nd1UNmcVVcYnhG6ffFZp6OWV86BQmyRKxlYMejmwo+5gULruwDWLXYphsvjeV4DU890s 1sbDai1ZQSlb3DQQzpMr0f3EBnSn9cXIHDUQ69sb3G8byBjjkAKmz1beBMDg/Z7DSkLB Xp8uofLopGxyGY+u6GOdbzGJnfUsMuDthyVEPKe8OZffl7e0Fu4nIRI1qRKB2fP3hTQq vm2Q== X-Gm-Message-State: AHPjjUiS5lkE6xFTBqXE9pO4Cc4AYqZ6oIbWBOG+RcHAm/tJ2Qat1dql xw8ep804Ir5R0jsbqu/D8w== X-Google-Smtp-Source: ADKCNb6XlR4bCNQehhxQaTHD2pY6pjfKmOPbFhdyvOODyOEneZC/lJ5oy2ZDsKq1VE0gp7rlIVOGjQ== X-Received: by 10.25.228.84 with SMTP id b81mr764016lfh.26.1504271069504; Fri, 01 Sep 2017 06:04:29 -0700 (PDT) Received: from enkidu.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id m129sm21754lfg.26.2017.09.01.06.04.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Sep 2017 06:04:28 -0700 (PDT) From: Marcin Wojtas To: edk2-devel@lists.01.org Date: Fri, 1 Sep 2017 15:08:18 +0200 Message-Id: <1504271303-1782-7-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1504271303-1782-1-git-send-email-mw@semihalf.com> References: <1504271303-1782-1-git-send-email-mw@semihalf.com> Subject: [edk2] [platforms: PATCH 06/11] Applications/SpiTool: Fix bug in error test X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jinghua@marvell.com, ard.biesheuvel@linaro.org, agraf@suse.de, leif.lindholm@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" From: Ard Biesheuvel Fix a misplaced closing parenthesis. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas --- Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c index b6dc54f..e6e1007 100644 --- a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c +++ b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c @@ -378,7 +378,7 @@ EFI_STATUS Status; FilePath = (CHAR16 *) FileStr; Status = ShellIsFile (FilePath); // When read file into flash, file doesn't have to exist - if (EFI_ERROR(Status && !(Flag & READ_FILE))) { + if (EFI_ERROR (Status) && !(Flag & READ_FILE)) { Print (L"sf: Wrong FilePath parameter!\n"); return SHELL_ABORTED; }