[edk2,platforms:,08/11] Applications/SpiTool: Fix 32-bit issues

Message ID 1504271303-1782-9-git-send-email-mw@semihalf.com
State New
Headers show
Series
  • Untitled series #3719
Related show

Commit Message

Marcin Wojtas Sept. 1, 2017, 1:08 p.m.
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Fix casting and related issues to make this code build for 32-bit ARM.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Signed-off-by: Marcin Wojtas <mw@semihalf.com>

---
 Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.3.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Sept. 1, 2017, 2:56 p.m. | #1
On Fri, Sep 01, 2017 at 03:08:20PM +0200, Marcin Wojtas wrote:
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> 

> Fix casting and related issues to make this code build for 32-bit ARM.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Signed-off-by: Marcin Wojtas <mw@semihalf.com>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c

> index e6e1007..ee14270 100644

> --- a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c

> +++ b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c

> @@ -418,7 +418,7 @@ EFI_STATUS              Status;

>      }

>    }

>  

> -  Buffer = (UINT8 *) Address;

> +  Buffer = (UINT8 *)(UINTN)Address;

>    if (FileFlag) {

>      Buffer = FileBuffer;

>    }

> -- 

> 1.8.3.1

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c
index e6e1007..ee14270 100644
--- a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c
+++ b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c
@@ -418,7 +418,7 @@  EFI_STATUS              Status;
     }
   }
 
-  Buffer = (UINT8 *) Address;
+  Buffer = (UINT8 *)(UINTN)Address;
   if (FileFlag) {
     Buffer = FileBuffer;
   }