From patchwork Wed Sep 6 12:58:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 111767 Delivered-To: patch@linaro.org Received: by 10.140.94.166 with SMTP id g35csp827636qge; Wed, 6 Sep 2017 05:59:52 -0700 (PDT) X-Google-Smtp-Source: ADKCNb78d/J4saSiYPxvZmh2FRfg7umS6npeXodf+OKf47AbRKH9mIFeFGowJ97AeIPh5ZxTFxFS X-Received: by 10.99.141.74 with SMTP id z71mr7439139pgd.407.1504702792262; Wed, 06 Sep 2017 05:59:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504702792; cv=none; d=google.com; s=arc-20160816; b=mqHn1Gf9jIz7PA7Sdkprcp72aQkNb7T1/K18X9OLqhGc/ongJJnscjBEYXmJYGk40w XI17R4MmSBmscuddK/5/s9MPwUCdybn68oE0N4R5FqWOe5ZwMrVB/rOn+sfOiuwtIqtv JmqeLHDliW4qdUu9l8bSOABqXNd4j2+PPEQRJ4NRDauesKAMa65bksvio1Hm//WFowPX q5ekiicjWVnkoTJFAEl4VyHC2Ps8DCKqMwW4rQXDXRwdISd4dTeZHZ+hor5WFZwpxjhN /VgRvLTI+GxcvyLWYcyKhtbULn2IBWyxAMZRxcztW+NkxTnBt4Q2nNW8EziCzxPTHC6Z nJrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=QvIC1UJu1WeFjF+MCRLBUcQMw/KasFwOTxSdms5GZ9E=; b=VmouSZDC1XTtFxPxrBPJNxHtxlw+C0otzDWHm438D4z5JjwtalurzCnWdAyV8dA6bM cUzaoQ35sJd9j2SGbdidoDL4R8JxtvetiCnd+dAnWER78g7yDK8XsB1jfTylNX8GjyIs J6mwTJfGEEr7qqD6A5j+F+FhXTSr80z5B2B3WAdMYD7i8psxiS5CdYi6qbgpXw5tv6sM pcKjYWraPw5x/teiFanlZHzpsP47erhYdO0fR1yVGc+tNipXg3Ges41k4WFHbk4nQZre BOwFN11ByAhdyCOdWbOMwDX9ej+P0Per4BL6mHNUDNRHbDmVcn7YxOlGdw6/joTRpYvt m65Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si1236678plm.22.2017.09.06.05.59.51; Wed, 06 Sep 2017 05:59:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932107AbdIFM7t (ORCPT + 26 others); Wed, 6 Sep 2017 08:59:49 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:61407 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754481AbdIFM7o (ORCPT ); Wed, 6 Sep 2017 08:59:44 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MVLtW-1dyp4n2ZOo-00YmEV; Wed, 06 Sep 2017 14:59:07 +0200 From: Arnd Bergmann To: Kalle Valo Cc: Arnd Bergmann , Colin Ian King , Bartosz Markowski , Govind Singh , Ryan Hsu , Srinivas Kandagatla , Rajkumar Manoharan , Ashok Raj Nagarajan , Ben Greear , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ath10: mark PM functions as __maybe_unused Date: Wed, 6 Sep 2017 14:58:53 +0200 Message-Id: <20170906125904.2588620-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:lplKrPTQdrG1ngYdQ38fk5EyYiH6HJ3adabrs2BPwJE+chqVijm J6yF7v0hF5jO6sCNbyV77+spU4hpF0JWLUUInjer9q9LRj76lZJbFJUXaVosAa6mDIjFved AwcVwzuU5/lR9PAGZTBaYcR9ZHiwLiUxSQ1oK6s6+JZMjwytfqxNVjrgYaCZT21dB5UHB35 nWwmaFpu0HqzEot0ZKm8g== X-UI-Out-Filterresults: notjunk:1; V01:K0:alKtr2AdNSA=:qvE8/+NnNZ1ZcZrynm0Z3Z 0p09nFrJKxjaf/ylNeAThs3KwViy+PMTjhbqXn0T6661ws2KXt9qDixMU3vFbuEJSYgUXUBtM 6RDMWcXSddrRRrZ6MXGj2rjrPnEKqOWdN6JpwErBCjstG+SzW5jGnyVcvt5Ba7wSP3mEUM3Se hkJFS51fer0k+0Xg+7APn3CeRGnq5yuNJ5H/9h+jGKjLHGbMbkDOTg8HAxTwkFtvzzzOCpKDs dzGYmp6aNuzxvJ2MiUXrcykE0Jt1zgfZGbUW32+i30IohxAv4hmVUuTVTH+2vYDLjUF953UwO RChnUC6pksQ2E8wCeltNqhpnxuZmFaKVhw89p6o63Cn20iDSwFtNW06AbgEL7aFtQZnh3als0 uM1JK0F3/bkiS9ScDSA7J1SOBL6zOydibHF7vT6pd4Rlb367YZy/yPYMZxY1cDOaDLxj0Zz9/ Zs7oSSLELLVU+b5H/E/LALapkg6H09IlA9dPhdPMTc1bW7NXvPncHyRPgXIf4Mj9cddbTKk4H aYsiFiyQGIcpRJNlSWgRCGewuo4ZhxT8tx52k9/eX4Par7Ul01o6edid85Rkcht1ygP7As75Z hHgtoZr2ltgNKjfW4mJy59eLchBpPEPRXgVjjPQZDatyR2L2Kz/JiLZ1YSfl9P8QfEj2ackaa 268D9XJk5C/GfqoLXjylFTSFYoPhdZU2nbmawKUYMXCvZAJRTjoxIY3OdtpxkGgrnHvUKheIU WbywsBQjSa5K4nfS52C/WO9SB2WwjgVopL2oNw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_PM_SLEEP is disabled, we get a compile-time warning: drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function] static int ath10k_pci_pm_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function] static int ath10k_pci_pm_suspend(struct device *dev) Rather than fixing the #ifdef, this just marks both functions as __maybe_unused, which is a more robust way to do this. Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath10k/pci.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.9.0 diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index bc1633945a56..195dafb98131 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -3396,9 +3396,7 @@ static void ath10k_pci_remove(struct pci_dev *pdev) MODULE_DEVICE_TABLE(pci, ath10k_pci_id_table); -#ifdef CONFIG_PM - -static int ath10k_pci_pm_suspend(struct device *dev) +static __maybe_unused int ath10k_pci_pm_suspend(struct device *dev) { struct ath10k *ar = dev_get_drvdata(dev); int ret; @@ -3414,7 +3412,7 @@ static int ath10k_pci_pm_suspend(struct device *dev) return ret; } -static int ath10k_pci_pm_resume(struct device *dev) +static __maybe_unused int ath10k_pci_pm_resume(struct device *dev) { struct ath10k *ar = dev_get_drvdata(dev); int ret; @@ -3433,7 +3431,6 @@ static int ath10k_pci_pm_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(ath10k_pci_pm_ops, ath10k_pci_pm_suspend, ath10k_pci_pm_resume); -#endif static struct pci_driver ath10k_pci_driver = { .name = "ath10k_pci",