diff mbox series

net: ethernet: ti: netcp_core: no need in netif_napi_del

Message ID 1504798350-790-1-git-send-email-ivan.khoronzhuk@linaro.org
State Accepted
Commit e333ac1f1db09e37425c90bb6cf3dec721a6d71d
Headers show
Series net: ethernet: ti: netcp_core: no need in netif_napi_del | expand

Commit Message

Ivan Khoronzhuk Sept. 7, 2017, 3:32 p.m. UTC
Don't remove rx_napi specifically just before free_netdev(),
it's supposed to be done in it and is confusing w/o tx_napi deletion.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

---
Based on net-next/master

 drivers/net/ethernet/ti/netcp_core.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.7.4

Comments

David Miller Sept. 9, 2017, 3:54 a.m. UTC | #1
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

Date: Thu,  7 Sep 2017 18:32:30 +0300

> Don't remove rx_napi specifically just before free_netdev(),

> it's supposed to be done in it and is confusing w/o tx_napi deletion.

> 

> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>


Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index eb96a69..437d362 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -2145,7 +2145,6 @@  static void netcp_delete_interface(struct netcp_device *netcp_device,
 
 	of_node_put(netcp->node_interface);
 	unregister_netdev(ndev);
-	netif_napi_del(&netcp->rx_napi);
 	free_netdev(ndev);
 }