From patchwork Mon Sep 11 13:01:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112180 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5759109pji; Mon, 11 Sep 2017 06:01:58 -0700 (PDT) X-Google-Smtp-Source: ADKCNb4OlLPqtie/97zXPM79YFFJUcOpV9FQ/nWEUVxTGiyuiomwHEP7h10fgwU3TZmApLS/+uJF X-Received: by 10.84.136.1 with SMTP id 1mr4039697plk.101.1505134918253; Mon, 11 Sep 2017 06:01:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134918; cv=none; d=google.com; s=arc-20160816; b=o9h87yXajVW7EgMt/KtQSLfx6izeDrTeBgGgfU6WeOnCb6OWh1ttuzTHweAX/I52ds pi0WcJBHxnIlQZTsUo6ZcA/TLQ1ywH28jLXx7Tn5XldncomBUWr36seC9G8bmeXwb3Ju WwFbpmwdfO9yJ494pmtGOQQnof3EstH+xduUez8iCyFeEDOYA4JbpJ6GUdB9X1KutDX1 FG2lT/PHpoR9p5FGvuf+kihYNVzue4BtGOx5TvHj8QO5LqB3J3ANUsWejhaM0B0+z7c1 86kM0Ke3XkrN9RISuYb/1y9E6nAkz2QdB8REWrQdO8TWwgWxc4nT0rOgO7ZE+EiUxDgc FnHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=n6pNd+oIaZZaEWsO4aUqOErHPYJTdB8dzajXRk2tQwk=; b=kYdBb3htBHpuG484IaXOMXp3JV3pDuNrGXTAFTMHCoZddov85GHCoe7bh6IoMYwIQe vunTCW5VjhvL7q0sU0xgB65fGD9LUvIJBx8liIRw0X34v2m3Q7aaZQTKXlodMA3f3t2V PP9EhTfNGpqR9RGslkfq/YSpq0Rl95tf2dhHrcf6TzJO+0fdGExntoU3MlgBZxkk5BsA zEVM2jzey4JYAJxyfgq5tXoUWmnDiOdiZ2IxBRSFZ6iTuZRVKSTY2E5ClLviC2XnryQT L+S2kyyBU/7Y1UroUciCKiY+M/Sy2dC3RtLeTPZiUUDeRS68+dzVoUZLCF8W0VSP2+sy SPtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=RXrY9tH7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o71si2022174pfa.380.2017.09.11.06.01.57; Mon, 11 Sep 2017 06:01:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=RXrY9tH7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdIKNBv (ORCPT + 26 others); Mon, 11 Sep 2017 09:01:51 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:42227 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbdIKNBt (ORCPT ); Mon, 11 Sep 2017 09:01:49 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4X001997; Mon, 11 Sep 2017 22:01:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4X001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134880; bh=n6pNd+oIaZZaEWsO4aUqOErHPYJTdB8dzajXRk2tQwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RXrY9tH7UWyRqekFrCa+r8ye8LCIGm7fqJwHjYMCd+1ch5AWqEwaJtVYUalJ5NcL2 mQQnmKEs5xv6jeII3AxABjwlig6vhwqwf4HUzucW0lEWgsRZ62NLI0HsoCUFqNwTBz 6jcz6qUO7oCSmNJD2MC8iooDY7J6/iFPN+vwNvPezYcH/Lr6eIZDmAmWs0DOT1Cd6w 4oQAArdApNR25U2uYhU5tLWgAx+ziy9OtOqi5UtLRUUR0Pt7gFpiWSwyrNbR9qMwbl 0gY1EUUhlIAtLTeuCUTdAYAyN56+EIRXTkVGGP6qd9Yq2bSsP6QHkHyU5vv6BXg/ei wmGECciPV9ugQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 1/5] nvmem: imx-iim: use stack for nvmem_config instead of malloc'ing it Date: Mon, 11 Sep 2017 22:01:00 +0900 Message-Id: <1505134864-11975-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nvmem_register() copies all the members of nvmem_config to nvmem_device. So, nvmem_config is one-time use data during probing. There is no point to keep it until the driver detach. Using stack should be no problem because nvmem_config is pretty small. Signed-off-by: Masahiro Yamada --- drivers/nvmem/imx-iim.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/imx-iim.c b/drivers/nvmem/imx-iim.c index 52ff65e..a599260 100644 --- a/drivers/nvmem/imx-iim.c +++ b/drivers/nvmem/imx-iim.c @@ -34,7 +34,6 @@ struct imx_iim_drvdata { struct iim_priv { void __iomem *base; struct clk *clk; - struct nvmem_config nvmem; }; static int imx_iim_read(void *context, unsigned int offset, @@ -108,7 +107,7 @@ static int imx_iim_probe(struct platform_device *pdev) struct resource *res; struct iim_priv *iim; struct nvmem_device *nvmem; - struct nvmem_config *cfg; + struct nvmem_config cfg = {}; const struct imx_iim_drvdata *drvdata = NULL; iim = devm_kzalloc(dev, sizeof(*iim), GFP_KERNEL); @@ -130,19 +129,17 @@ static int imx_iim_probe(struct platform_device *pdev) if (IS_ERR(iim->clk)) return PTR_ERR(iim->clk); - cfg = &iim->nvmem; - - cfg->name = "imx-iim", - cfg->read_only = true, - cfg->word_size = 1, - cfg->stride = 1, - cfg->owner = THIS_MODULE, - cfg->reg_read = imx_iim_read, - cfg->dev = dev; - cfg->size = drvdata->nregs; - cfg->priv = iim; - - nvmem = nvmem_register(cfg); + cfg.name = "imx-iim", + cfg.read_only = true, + cfg.word_size = 1, + cfg.stride = 1, + cfg.owner = THIS_MODULE, + cfg.reg_read = imx_iim_read, + cfg.dev = dev; + cfg.size = drvdata->nregs; + cfg.priv = iim; + + nvmem = nvmem_register(&cfg); if (IS_ERR(nvmem)) return PTR_ERR(nvmem);