From patchwork Mon Sep 11 13:01:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112181 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5759420pji; Mon, 11 Sep 2017 06:02:07 -0700 (PDT) X-Google-Smtp-Source: ADKCNb6FBgOTO99TLWdqwe6ZHqlR2SkButpfeGsImTeV+5SFt3TkuJzXIxt8rl8Psg3n0/Z961QE X-Received: by 10.84.209.197 with SMTP id y63mr13575229plh.436.1505134927667; Mon, 11 Sep 2017 06:02:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134927; cv=none; d=google.com; s=arc-20160816; b=sBJ89KL328TsmO9SblpmMw34Op5JVMU03BfLj7Wnp0porH+iU3HkVeUFlsojTVL6S0 xnMN9XyHK8viqehWzHa0ktsn2MOI+ctqf0lMWNPPl1Lm2uekkaUXnCTSK/SJfr2S5ZUI jvjTEHXUfKcYkFKlaNlfZnrbAJZZLlQoMlX6+lnCJBu7fTkoHxJN8AcqXp/jULbNN2qi +NNPs6fNXfoCOOxfbueM6GwPNOUcJwQRgjidc5HenQc3X//990KQfv1PKJB/PYrHXXQm R09ytpGiTdlhrgV1ReQvWKuZNwUcr01SwmKQYjTWszNJiEYweLj3QaulBn9yc3qhk/wH EnWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=KKy942Lk7jTu/OdoX6JFhp2dbbuBTrKU82hCXG7jjkU=; b=CzLjRg51iHJR0r0Hy0PynrdHi1kJj8HNwLauV6AuApZylsoD3Pra8TdgziuAuV/Ijc JmqqdMPGHfXq0lgV6jckt863jLwM5TX7R5HlBYXpBU3VroUSOYbdUnTfhASN849+m0+D VweMsWrbJvnx3CpK/Y4FW3TTRPCxDtLXzLw8IwyQIhjJA6PuUYVGvS+BWeM134Je7JXf G5V6gDm70dXeKwkMhqQ3pkiiIytfhWJRxhVGc9PXrNn3mOhmKlB031JGdiQ0ICqwQi7H 6Sy8bJIyKJ5x77KhzGY73XUXZTptrSbh01+kytmyhNcKDCsMqtwnsFW7/4h6Im1CIRw2 /kzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=F/La4MBf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si5904940pgc.459.2017.09.11.06.02.07; Mon, 11 Sep 2017 06:02:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=F/La4MBf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbdIKNBu (ORCPT + 26 others); Mon, 11 Sep 2017 09:01:50 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:42228 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdIKNBt (ORCPT ); Mon, 11 Sep 2017 09:01:49 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4a001997; Mon, 11 Sep 2017 22:01:22 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4a001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134882; bh=KKy942Lk7jTu/OdoX6JFhp2dbbuBTrKU82hCXG7jjkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F/La4MBfFmFJVfMJX+lT3WQFRn7MjalmWPiBd9O9lEqRaCtYVO5jXPT1l8psGlCo8 VMbv1dt3FQFcWRyxt2iWFNSgiuJoXRr9DzcFDh9NbnN8/4n3r/yLs+EfruBbKuYwR8 q0b2CsJe5H1bhyUDjoG6vTiBoCLX0axLMzXY5HwQuz5ZV0r5j68qal14x+2djn39dk 3kXn4Mc02bdjmSQm+AU4Y7YHHDnU0xyqs2ZSRWlFrNvo2W3yh1ROynQCnHX3l6er7L /B1xz61Q5qHJe/mGzrFCXBEDFeA0sisCbRALGR6W21P8uPeJeTOOAcnsAHjC4/B/24 Q4KN/GtZRtXqQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] nvmem: qfprom: fix different address space warnings of sparse Date: Mon, 11 Sep 2017 22:01:03 +0900 Message-Id: <1505134864-11975-5-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warnings: drivers/nvmem/qfprom.c:23:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/qfprom.c:23:30: expected void [noderef] *base drivers/nvmem/qfprom.c:23:30: got void *context drivers/nvmem/qfprom.c:36:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/qfprom.c:36:30: expected void [noderef] *base drivers/nvmem/qfprom.c:36:30: got void *context drivers/nvmem/qfprom.c:76:22: warning: incorrect type in assignment (different address spaces) drivers/nvmem/qfprom.c:76:22: expected void *static [toplevel] [assigned] priv drivers/nvmem/qfprom.c:76:22: got void [noderef] *[assigned] base The type of nvmem_config->priv is (void *), so sparse complains about assignment of the base address with (void __iomem *) type. Even if we cast it out, sparse still warns: warning: cast removes address space of expression Of course, we can shut up the sparse by marking __force, but a more correct way is to put the base address into driver private data. Signed-off-by: Masahiro Yamada --- drivers/nvmem/qfprom.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index 2bdb6c3..b96730e 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -17,15 +17,19 @@ #include #include +struct qfprom_priv { + void __iomem *base; +}; + static int qfprom_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct qfprom_priv *priv = context; u8 *val = _val; int i = 0, words = bytes; while (words--) - *val++ = readb(base + reg + i++); + *val++ = readb(priv->base + reg + i++); return 0; } @@ -33,12 +37,12 @@ static int qfprom_reg_read(void *context, static int qfprom_reg_write(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct qfprom_priv *priv = context; u8 *val = _val; int i = 0, words = bytes; while (words--) - writeb(*val++, base + reg + i++); + writeb(*val++, priv->base + reg + i++); return 0; } @@ -64,16 +68,20 @@ static int qfprom_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct resource *res; struct nvmem_device *nvmem; - void __iomem *base; + struct qfprom_priv *priv; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) - return PTR_ERR(base); + priv->base = devm_ioremap_resource(dev, res); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); econfig.size = resource_size(res); econfig.dev = dev; - econfig.priv = base; + econfig.priv = priv; nvmem = nvmem_register(&econfig); if (IS_ERR(nvmem))