From patchwork Mon Sep 11 13:01:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112183 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5760468pji; Mon, 11 Sep 2017 06:02:43 -0700 (PDT) X-Google-Smtp-Source: ADKCNb4TtbYX0I8y5J334Mg74GnJO0vfMQmasvVaJ1UHA0jdJYK1swOpAulye7cn15/FNWnWNkMr X-Received: by 10.99.95.204 with SMTP id t195mr11776919pgb.135.1505134963431; Mon, 11 Sep 2017 06:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134963; cv=none; d=google.com; s=arc-20160816; b=tBrOMvun4hHUts9UDJbsF9Keb94phpVfD//RtH3sTewv7u40J1HD7YpU5UblPHqNO7 3hq0ylSRVys7PGg2XUZJql6IyVhsWNoDc08k+siWXzs5TwtsuXlC/w00zi8EIX6IlYdb a6tDjaQMWXuBIfhs5Mu+eJ6bfmN7/yah5LFKiwhsWjR5RJ8RfnbWVhGYCbeI9aJAkY18 5Xm146aZpUImX9hUAW+RIOX9FpX7qShWw6loL3wqppdB0Rd8Nnj4RxPfLLxa9N/sqkck +Tn/x9mTh8eXoPRvg+zH5f0PqFVuabpGwMIDkCgzrlnuL+rPKS0zw0ZAlYjJ+90pkfl3 s7UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=XjJuoI8DZefJ4kMqn3Ylw8/xrv/j5RPGnE5deRFs0EY=; b=ciDzNPGdjRfumBZA6p9Qdd5m3zyhu625fta51j2MPC9ZysFH3O0zJBGBshC8rkGzMJ PX/CrozTOCjqu5a8P1wNyG2ba/XgmlT4J6qxHtEr8PezV0pate8NNwLPsnBGNAP2FMeu Zd2a+mLhX4UMOOhv/jczpyfbI1eCouROGVLUi2fXumf6tqA4scMy6MmdammZ8yFSgGso eP3jUHd+cVg9G1RTxmZfVUNOFhijWwmMCetE0VChrAIZjPpuVCY65IBtUhjbCpUSlAEl YVevZpHlrW82/UqOeA1Goo5dipbQUzr4tOUnBf7nXIs8AHeofcfsjaz+TBY8m5d/iBdu ds0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ptXHsyUO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si5920772pgr.677.2017.09.11.06.02.42; Mon, 11 Sep 2017 06:02:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ptXHsyUO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbdIKNCk (ORCPT + 26 others); Mon, 11 Sep 2017 09:02:40 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:43684 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbdIKNCi (ORCPT ); Mon, 11 Sep 2017 09:02:38 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4Z001997; Mon, 11 Sep 2017 22:01:21 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4Z001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134882; bh=XjJuoI8DZefJ4kMqn3Ylw8/xrv/j5RPGnE5deRFs0EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ptXHsyUOvCXpghicxzYlJRRNlk2YkpGL3I43Ps1Z6GqpNpZQC6+msgWm23loJY9aK uCNkO/g15byAL7wVVI4nKwityag4Vy8y55UK0SwScx4Fm/PPuVjGvA0AmN8LeWYBeA FfU/2Apv1g96kwmBlLJEUvgXCop30NLuZIc1qLn5ZAspkpRquu3By8eTbbHNI/4KOF I1atUnA70E0VuLj5/jqmOVbo7kUjrJdo9G0mtTWLVgcCuE+ipbTMeEFSUO7iRTUocr vTvK5hcJsinHZ5e7W/eb7GnzljI7TGCtS5OccbAF9F/1Po8vrL/rPPxD3M3NdnplUx xogDULPccIzew== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger Subject: [PATCH 3/5] nvmem: mtk-efuse: fix different address space warnings of sparse Date: Mon, 11 Sep 2017 22:01:02 +0900 Message-Id: <1505134864-11975-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warnings: drivers/nvmem/mtk-efuse.c:24:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/mtk-efuse.c:24:30: expected void [noderef] *base drivers/nvmem/mtk-efuse.c:24:30: got void *context drivers/nvmem/mtk-efuse.c:37:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/mtk-efuse.c:37:30: expected void [noderef] *base drivers/nvmem/mtk-efuse.c:37:30: got void *context drivers/nvmem/mtk-efuse.c:69:23: warning: incorrect type in assignment (different address spaces) drivers/nvmem/mtk-efuse.c:69:23: expected void *priv drivers/nvmem/mtk-efuse.c:69:23: got void [noderef] *[assigned] base The type of nvmem_config->priv is (void *), so sparse complains about assignment of the base address with (void __iomem *) type. Even if we cast it out, sparse still warns: warning: cast removes address space of expression Of course, we can shut up the sparse by marking __force, but a more correct way is to put the base address into driver private data. Signed-off-by: Masahiro Yamada --- drivers/nvmem/mtk-efuse.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.7.4 Acked-by: Sean Wang diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index fa7a0f6..c4058b5 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -18,15 +18,19 @@ #include #include +struct mtk_efuse_priv { + void __iomem *base; +}; + static int mtk_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct mtk_efuse_priv *priv = context; u32 *val = _val; int i = 0, words = bytes / 4; while (words--) - *val++ = readl(base + reg + (i++ * 4)); + *val++ = readl(priv->base + reg + (i++ * 4)); return 0; } @@ -34,12 +38,12 @@ static int mtk_reg_read(void *context, static int mtk_reg_write(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct mtk_efuse_priv *priv = context; u32 *val = _val; int i = 0, words = bytes / 4; while (words--) - writel(*val++, base + reg + (i++ * 4)); + writel(*val++, priv->base + reg + (i++ * 4)); return 0; } @@ -50,19 +54,23 @@ static int mtk_efuse_probe(struct platform_device *pdev) struct resource *res; struct nvmem_device *nvmem; struct nvmem_config econfig = {}; - void __iomem *base; + struct mtk_efuse_priv *priv; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) - return PTR_ERR(base); + priv->base = devm_ioremap_resource(dev, res); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); econfig.stride = 4; econfig.word_size = 4; econfig.reg_read = mtk_reg_read; econfig.reg_write = mtk_reg_write; econfig.size = resource_size(res); - econfig.priv = base; + econfig.priv = priv; econfig.dev = dev; econfig.owner = THIS_MODULE; nvmem = nvmem_register(&econfig);