procfs: remove unused variable

Message ID 20170911200231.3171415-1-arnd@arndb.de
State Accepted
Commit 6dec0dd4a627d15510c9435c4dbf4b9f4ffeeeb7
Headers show
Series
  • procfs: remove unused variable
Related show

Commit Message

Arnd Bergmann Sept. 11, 2017, 8:02 p.m.
in NOMMU configurations, we get a warning about a variable
that has become unused:

fs/proc/task_nommu.c: In function 'nommu_vma_show':
fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]

Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 fs/proc/task_nommu.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.9.0

Comments

Michal Hocko Sept. 12, 2017, 7:43 a.m. | #1
On Mon 11-09-17 22:02:16, Arnd Bergmann wrote:
> in NOMMU configurations, we get a warning about a variable

> that has become unused:

> 

> fs/proc/task_nommu.c: In function 'nommu_vma_show':

> fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]

> 

> Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")


this sha doesn't exist in Linus tree. I guess it comes from linux-next.
The merged commit is 1240ea0dc3bb ("fs, proc: remove priv argument from
is_stack")

Other than that
Acked-by: Michal Hocko <mhocko@suse.com>


Thanks for catching this and the fix!

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  fs/proc/task_nommu.c | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c

> index dea90b566a6e..b00b766098fa 100644

> --- a/fs/proc/task_nommu.c

> +++ b/fs/proc/task_nommu.c

> @@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,

>  			  int is_pid)

>  {

>  	struct mm_struct *mm = vma->vm_mm;

> -	struct proc_maps_private *priv = m->private;

>  	unsigned long ino = 0;

>  	struct file *file;

>  	dev_t dev = 0;

> -- 

> 2.9.0

> 


-- 
Michal Hocko
SUSE Labs

Patch

diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
index dea90b566a6e..b00b766098fa 100644
--- a/fs/proc/task_nommu.c
+++ b/fs/proc/task_nommu.c
@@ -145,7 +145,6 @@  static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
 			  int is_pid)
 {
 	struct mm_struct *mm = vma->vm_mm;
-	struct proc_maps_private *priv = m->private;
 	unsigned long ino = 0;
 	struct file *file;
 	dev_t dev = 0;