From patchwork Tue Sep 12 15:59:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 112323 Delivered-To: patch@linaro.org Received: by 10.80.202.13 with SMTP id d13csp109669edi; Tue, 12 Sep 2017 08:59:17 -0700 (PDT) X-Received: by 10.98.89.91 with SMTP id n88mr15692776pfb.280.1505231957474; Tue, 12 Sep 2017 08:59:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505231957; cv=none; d=google.com; s=arc-20160816; b=g1UPEbMOLMMEDzUC4/1kI7C5JpEAmq/fU/ZZs28gJ6RHQiDc7APKeWZ1lafBKUjGVg 9vKnti1u6UMaNCMY1C2V4j42l/2l0+oyEKWFukV/Ggcep5gNRkkC67J/59TZq4CbICYd QvSN6i72NnTTi42Q/ad1V6cgxqyioyCF6W/qSt/o2MeZ/Np3Qc6OzogApTqmrmGogKv6 sr92Dl9rkJIv7YNS5L47i5YRZ6qpbuc9sThjbh21ywqcjUDJ9g4VxxXZ514wLC1lmozs L7/rJgjO0BdVYE4DM9n89X2S0iGz6cmE1IqtM5ok0ELVwSJaKuKLJZYo81tQ1KeWj14J 8DYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=7AqaKDf/WLDUBRHylBnShu93CfH522+bRXI8Fp5gjY0=; b=jgwcHUSQsj/TADkkesgKTWqhFyZ8dBGtUay3TxfvHLfDET+KMGCLbE4/pGqmlFS1jM BUmIhHdidpiR3bD0eqd7GW51v+9ZnXz3f65OJfFiNOyUkcI+Xzphsjsc7gBQCLPLnzRM wv/u5ao2RdJnJTX/EJY2OKe13Ejl2fIRhJLnejjZO5PBJiR3aVDUgPjOoSdzFWUYDK1p mx+NZJgAbHWF7EyF3X4W75GcbMnm5AMYAW7EDCWGmxPAbM0EZQ3XW0EAOLN/w+OjXDxq HptRdAYKZ31Ne8hIGhV4ymM3o4Y+vCvXWMb4lY16x28ubn2GD6JeGFVmXTuanhi4ZREX 1oyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=ZXYs4Srb; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id g62si1104575pfb.390.2017.09.12.08.59.16; Tue, 12 Sep 2017 08:59:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=ZXYs4Srb; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id AC9A87846B; Tue, 12 Sep 2017 15:59:12 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by mail.openembedded.org (Postfix) with ESMTP id 1824478484 for ; Tue, 12 Sep 2017 15:59:10 +0000 (UTC) Received: by mail-wr0-f170.google.com with SMTP id m18so23767645wrm.2 for ; Tue, 12 Sep 2017 08:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=9hv2XIU8US568hEkAuW2/6Y4Q7yGXfPUOI78G0YGdpU=; b=ZXYs4SrbUEDD/mPfGgWd3UVsCaoQzsGUmxEGiXan4RoSNO0IX88wV6WxQc0dxQjzXk v95ZWYUrQ/ko347AIne2caCTlNsnoTNnw62JVlLPhqdORMXs61yiNfFh5ybsxepavHCb JvjuW0F9vWOdpk2L7RPSTatSPytoGo9oIvEZTo9emzYmhxWrgogiFMXhvHrIGI4ghspS /pDQ1EZv7o2PwUmpuXe/06qCGIoJFq2vVypt6mEOnOMNf/Q2cWSBIpRgPadocqCFLxiw qAPiLG26JV50GNjvkFzWNo4fCCcwlgfqU7ALRP8bC50GIOqyDog1jMnD4TMPfIQMVWq8 Wf7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=9hv2XIU8US568hEkAuW2/6Y4Q7yGXfPUOI78G0YGdpU=; b=JayKCpjS6VPE6//u00IONuLpQ78bPDz8V5RE8Jt2kpZqDnsHWt1LlVz8e1aYbJTdsO etINu3AvHehni65ncutbKbjMV8Z2B4CkKc/ePmokVQvJo0SAs/ihjhunHcU0/0u31Vd6 BQ3/EGVIYO720LK/iDvKBAWgoaVMLUHaaMwuz31jPB9uqdLJ58rdK8zPTEllRrlXO54x Kz/4JAqy0y+G3BCAQ8koOwG9Ycq9nouLD0+Ldz7YynsdlSTGyHLjei4LZuG8chwrmTjL +uDSz6QeoRbKBms//RKn36aWvAnRRJryAiKd3DZ6GZ2g3lYuhK+T53st0JOFGGJgTEfg N+KQ== X-Gm-Message-State: AHPjjUjopSJpCJBBrAjOUnkt0GPn7upZxc226SCihKd8snweTxl9hpT9 WaSMiv00n6WIP9Bu8D4= X-Google-Smtp-Source: ADKCNb5YEw8tuu1RUd8vncjdY3tcGwVO8Njqnb7cBkEs6t2oRiEI6Ep4hEAPNvZQ88V0ZzB+YjdcVQ== X-Received: by 10.223.164.206 with SMTP id h14mr12360472wrb.221.1505231950969; Tue, 12 Sep 2017 08:59:10 -0700 (PDT) Received: from flashheart.burtonini.com (home.burtonini.com. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id f188sm13884603wme.21.2017.09.12.08.59.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Sep 2017 08:59:09 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Tue, 12 Sep 2017 16:59:06 +0100 Message-Id: <20170912155906.29716-1-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [OE-core] [PATCH] allarch: don't reset baselib X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org allarch currently resets baselib to "lib" in an attempt to keep allarch recipes uniform. However if the real value for $baselib is actually needed, for example in a multilib environment where $baselib is lib64 for standard binaries and the allarch package is using postinst intercepts which need to know the real value of $libdir, then a non-existant or incorrect $libdir will be used. Real world example: liberation-fonts is allarch and inherits fontcache, which uses a postinst intercept to run fc-cache inside qemu-user. In a multilib configuration where normal libdir=/usr/lib64 and lib32 libdir=/usr/lib qemu will try running a 64-bit fc-cache with a 32-bit ld-linux, and predicatably the binary crashes. Signed-off-by: Ross Burton --- meta/classes/allarch.bbclass | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass index 51ba509cd0a..e0326039d0c 100644 --- a/meta/classes/allarch.bbclass +++ b/meta/classes/allarch.bbclass @@ -13,7 +13,7 @@ python () { # Set these to a common set of values, we shouldn't be using them other that for WORKDIR directory # naming anyway - d.setVar("baselib", "lib") + #d.setVar("baselib", "lib") d.setVar("TARGET_ARCH", "allarch") d.setVar("TARGET_OS", "linux") d.setVar("TARGET_CC_ARCH", "none") @@ -48,4 +48,3 @@ python () { elif bb.data.inherits_class('packagegroup', d) and not bb.data.inherits_class('nativesdk', d): bb.error("Please ensure recipe %s sets PACKAGE_ARCH before inherit packagegroup" % d.getVar("FILE")) } -