[v2,01/14] usb: gadget: Move USBNET_DEVADDR option out of g_dnl

Message ID ba86e9aa151de6a619ab1ecb247647e49e15ae1e.1505242834.git-series.maxime.ripard@free-electrons.com
State Accepted
Commit 5506ff149d4aa4b76f162a71c2cf68c2b00d38e9
Headers show
Series
  • sunxi: convert musb to the device model and enable usb_ether
Related show

Commit Message

Maxime Ripard Sept. 12, 2017, 7:01 p.m.
The USBNET_DEVADDR has nothing to do with the USB download gadget, but
rather with the USB Ethernet gadget. Move it out of the if statement.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/usb/gadget/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lukasz Majewski Sept. 13, 2017, 10:37 a.m. | #1
On 09/12/2017 09:01 PM, Maxime Ripard wrote:
> The USBNET_DEVADDR has nothing to do with the USB download gadget, but
> rather with the USB Ethernet gadget. Move it out of the if statement.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>   drivers/usb/gadget/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 225b66bc95ff..d52626908846 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -119,10 +119,10 @@ config G_DNL_VENDOR_NUM
>   config G_DNL_PRODUCT_NUM
>   	hex "Product ID of USB device"
>   
> +endif # USB_GADGET_DOWNLOAD
> +
>   config USBNET_DEVADDR
>   	string "USB Gadget Ethernet device mac address"
>   	default "de:ad:be:ef:00:01"
>   
> -endif # USB_GADGET_DOWNLOAD
> -
>   endif # USB_GADGET
> 

Acked-by: Ɓukasz Majewski <lukma@denx.de>

Patch

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 225b66bc95ff..d52626908846 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -119,10 +119,10 @@  config G_DNL_VENDOR_NUM
 config G_DNL_PRODUCT_NUM
 	hex "Product ID of USB device"
 
+endif # USB_GADGET_DOWNLOAD
+
 config USBNET_DEVADDR
 	string "USB Gadget Ethernet device mac address"
 	default "de:ad:be:ef:00:01"
 
-endif # USB_GADGET_DOWNLOAD
-
 endif # USB_GADGET