From patchwork Tue Sep 12 20:10:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 112391 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp44258qgf; Tue, 12 Sep 2017 13:11:27 -0700 (PDT) X-Google-Smtp-Source: AOwi7QC5g5+SXvfB/g9aC87cKHOOM63RDd8/h3yAtcVPPFw0eSZQI/pmaAsYXBhjrSOZt8Xo1utA X-Received: by 10.107.167.129 with SMTP id q123mr3359710ioe.90.1505247087554; Tue, 12 Sep 2017 13:11:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505247087; cv=none; d=google.com; s=arc-20160816; b=dZRzYBc8wLYoBmt5zlTXqgKqlNmx1S9MEZUzUmRzkhVa3e8EM7hEpn+88h9Hju8+qL bAtCAuBOT+uGHVEJV4Sr4wBPyHC/6PMm+0pVpPFY1N1M0OssN6cL5c7j67OHYnMBWcWV 1mwyti1z/wCOmNdrgSZzO8xO56XapYwA76jeBfj0loKjBYKVLUEO3mZeZtAi41SmxYos TmqY1r4aQ2ED361h+IsVGIpI9WRKFTC2bSDyqZ4X4NcJ1DGgiRdHgnSFkn1stYgm72Tl OdhmQULSH5L0MARbSwq49LV5kThCg4o8GW/1/JNwFjrFODzfZw1BaVBg1RzkQiVlnQSd BhhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=ibk29k8MThE/2zSBtUzRPQMJBEwMEldQDxYKz8UnDyk=; b=BAn5pVORuk50531A7WS63p8KynwuzRVK+BDj+Obuk0dhaOS7rAcvQUg14nJwW3t4DI /w6daOgcVEUZFf/ljeHV1aDSRq0K9rRElLkOhUMR26vaO3T/rtOCA6L1DbtFi2YfMbNJ IqrJOEi56Q1gQhGMH7Sq54C6TCcE5nXGsksuv9gWvZrBjCN7j2+b6cXxcqH9yIpS3XnX oabR5RvySncL8YTUwqpsKDGuonrn3RwMvH5iPJI6GvDLlJI3YeGc6Kf0KZJfX43LVTrg /RxxMvYedtDzusu8ejyZ2DqK5MMGkUkRc1t/dbmCqs5BiRqrI3t6NQAo7lgP6SAAkOg5 jzQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m189si1053474itc.153.2017.09.12.13.11.26; Tue, 12 Sep 2017 13:11:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbdILULZ (ORCPT + 26 others); Tue, 12 Sep 2017 16:11:25 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:56502 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdILULV (ORCPT ); Tue, 12 Sep 2017 16:11:21 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MA6Q5-1dh5tW3kZF-00BIdJ; Tue, 12 Sep 2017 22:11:04 +0200 From: Arnd Bergmann To: David Ahern , Shrijeet Mukherjee Cc: Arnd Bergmann , "David S. Miller" , Julian Anastasov , Matthias Schiffer , Wei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: vrf: avoid gcc-4.6 warning Date: Tue, 12 Sep 2017 22:10:53 +0200 Message-Id: <20170912201100.3680915-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 X-Provags-ID: V03:K0:KHrgLJ62MRueR7RXhu+tEHGgLFeVw2ZQIiL9E6rcg4qWQCtDfwR 0LSLeTHrSWIlpuKsr+yq+z9S/3Yybl7sAOZVq8bRF5mASrBqCn99YRpM3FHPt34957Ct/f+ 6avfdkIYKVxZ+pO0UIKGtNfHtHi1VxCmgMXiSy79uhJ7cBMCfpsYKDndck6R08gTd07EbcS SVsj5LHzxxuuQ7XvKFRAw== X-UI-Out-Filterresults: notjunk:1; V01:K0:EucAqCoaf+k=:OEnogRyJKQKQ7Wng8rLNfQ cWSa6phc9bFtUXK0LsI9V5lWUTjO7LS3Nq3CLyDlgcaEuFbvZURxBL49hfZQwJ/Bi+apgdBFc 1cBmULIrJH9cJz0YCLXDU5Uq61/IDc97I+HZW1+c+a8IpeGxnydIvBKQXCclbK5nH29cy4e9M blOXKV+rhPOP506OxhX2uDfnspsJS9kHZ0XmUPnq+aqRbhVd9Ik6o5ZPi+Im/RXxJbxee9Dmt QlWpepn/FXEj7AfQAf2zRrv+ydR/s6aMIaAopeQl5UwjW8iOC/oE/5sQfs/AIwQSg/IhpwAnR LWVdLg2t0/azjw5pWuOqZE/Y6MQA8zcbB2E3sSGGdej07q4ba0yKHjXUV877KBGhUvwbF+pA0 OcKcNw9kbFex+G7cs1W7lhy8965VWRbUHDJjkkk8lLsCbvtuYDODSh7+oyIamgwSuRlpylahu Wbn/scJPPRl6FB7GmaHGelj//ttk2wVD8QIsqHBi0VuEy8ko4b6ykBmhoYY3srbAkdSzgO9O7 RUjjf/IXXlP1MeSFij/linOQBrfQs79sCzT1FVlQsOBf418ELUiCw9p9t+Tu65C7lfLGOFRJA ok5k4Lk2KQq77UiE+jOCmOG7Jr7W0EcMZgpcw5CcmIUPCg1uCKVUi1/8OJIxQan6QV3GO9T1F ONbQXa77p/UDQH3v0D6UVBJE4CMLDJzn8Hb0GC4fo7vjOZ38uRbS/pjqbsaIb4FwG2axozZ91 p0hgbhMoit9+1g/jOz464czaDCJ1Sph+TsjOfGWKdQ5B9TqITWnP3gk28qc= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building an allmodconfig kernel with gcc-4.6, we get a rather odd warning: drivers/net/vrf.c: In function ‘vrf_ip6_input_dst’: drivers/net/vrf.c:964:3: error: initialized field with side-effects overwritten [-Werror] drivers/net/vrf.c:964:3: error: (near initialization for ‘fl6’) [-Werror] I have no idea what this warning is even trying to say, but it does seem like a false positive. Reordering the initialization in to match the structure definition gets rid of the warning, and might also avoid whatever gcc thinks is wrong here. Fixes: 9ff74384600a ("net: vrf: Handle ipv6 multicast and link-local addresses") Signed-off-by: Arnd Bergmann --- drivers/net/vrf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.9.0 diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 7e19051f3230..9b243e6f3008 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -957,12 +957,12 @@ static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device *vrf_dev, { const struct ipv6hdr *iph = ipv6_hdr(skb); struct flowi6 fl6 = { + .flowi6_iif = ifindex, + .flowi6_mark = skb->mark, + .flowi6_proto = iph->nexthdr, .daddr = iph->daddr, .saddr = iph->saddr, .flowlabel = ip6_flowinfo(iph), - .flowi6_mark = skb->mark, - .flowi6_proto = iph->nexthdr, - .flowi6_iif = ifindex, }; struct net *net = dev_net(vrf_dev); struct rt6_info *rt6;