[CLOUD-DEV,v2,1/11] framework: modular: extern SUBSYSTEM_FOREACH_TEMPLATE

Message ID 1505296826-16698-2-git-send-email-odpbot@yandex.ru
State Superseded
Headers show
Series
  • [CLOUD-DEV,v2,1/11] framework: modular: extern SUBSYSTEM_FOREACH_TEMPLATE
Related show

Commit Message

Github ODP bot Sept. 13, 2017, 10 a.m.
From: Yi He <yi.he@linaro.org>


Static SUBSYSTEM_FOREACH_TEMPLATE constraints the
functions to be instantiated in the source files
which invoke them, this causes code scatter shoots.

Signed-off-by: Yi He <yi.he@linaro.org>

Reviewed-by: Brian Brooks <brian.brooks@arm.com>

Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Reviewed-by: Kevin Wang <kevin.wang@arm.com>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>

---
/** Email created from pull request 139 (heyi-linaro:modular-pktio-ops)
 ** https://github.com/Linaro/odp/pull/139
 ** Patch: https://github.com/Linaro/odp/pull/139.patch
 ** Base sha: a1f50ad720e11a54b13c4786cad4687cb5c4ec2a
 ** Merge commit sha: ca3c52d51e6e80ba4bde91670d8b48a8a7ae1500
 **/
 frameworks/modular/odp_module.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/frameworks/modular/odp_module.h b/frameworks/modular/odp_module.h
index 1a9e178c3..59f67c8d4 100644
--- a/frameworks/modular/odp_module.h
+++ b/frameworks/modular/odp_module.h
@@ -206,7 +206,7 @@  struct odp_module_base {
  * subsystem and invoke init_global method for each.
  */
 #define ODP_SUBSYSTEM_FOREACH_TEMPLATE(subs, method, print)	\
-static int odp_ ## subs ##_## method(bool continue_on_errors)	\
+int odp_ ## subs ##_## method(bool continue_on_errors)		\
 {								\
 	int result = 0;						\
 	ODP_MODULE_CLASS(subs) * mod = NULL;			\