| Message ID | 20170913174419.34815-1-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | 392d474544ee469b5770842bf0c6fa7f7b17677e |
| Headers | show |
| Series | [oe,meta-initramfs,V3] klibc.bbclass: Add -mfloat-abi on arm | expand |
On Wed, Sep 13, 2017 at 10:44 AM, Khem Raj <raj.khem@gmail.com> wrote: > Default toolchain is not configured for hard float > therefore we need to pass the right -mfloat-abi option > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > Changes in V3: Append -mfloat-abi only on armv6 The change seems to be for armv7a and armv7ve, not armv6 ? > meta-initramfs/classes/klibc.bbclass | 2 ++ > meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass > index c9de58cec..1ec7b2b05 100644 > --- a/meta-initramfs/classes/klibc.bbclass > +++ b/meta-initramfs/classes/klibc.bbclass > @@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross" > # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version. > CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}" > CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork" > +CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" > +CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" > > CPP_forcevariable = "${CC} -E" > > diff --git a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb > index 867407723..8ca1ca727 100644 > --- a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb > +++ b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb > @@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3 > S = "${WORKDIR}/git/" > > EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'" > -CFLAGS += "${TUNE_CCARGS}" > > do_install () { > > -- > 2.14.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
On Wed, Sep 13, 2017 at 11:24 AM, Andre McCurdy <armccurdy@gmail.com> wrote: > On Wed, Sep 13, 2017 at 10:44 AM, Khem Raj <raj.khem@gmail.com> wrote: >> Default toolchain is not configured for hard float >> therefore we need to pass the right -mfloat-abi option >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> Changes in V3: Append -mfloat-abi only on armv6 > > The change seems to be for armv7a and armv7ve, not armv6 ? yes. its a typo in the comment I should have said arm7, I dont build for v6 > >> meta-initramfs/classes/klibc.bbclass | 2 ++ >> meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 - >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass >> index c9de58cec..1ec7b2b05 100644 >> --- a/meta-initramfs/classes/klibc.bbclass >> +++ b/meta-initramfs/classes/klibc.bbclass >> @@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross" >> # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version. >> CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}" >> CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork" >> +CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" >> +CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" >> >> CPP_forcevariable = "${CC} -E" >> >> diff --git a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb >> index 867407723..8ca1ca727 100644 >> --- a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb >> +++ b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb >> @@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3 >> S = "${WORKDIR}/git/" >> >> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'" >> -CFLAGS += "${TUNE_CCARGS}" >> >> do_install () { >> >> -- >> 2.14.1 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass index c9de58cec..1ec7b2b05 100644 --- a/meta-initramfs/classes/klibc.bbclass +++ b/meta-initramfs/classes/klibc.bbclass @@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross" # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version. CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}" CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork" +CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" +CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" CPP_forcevariable = "${CC} -E" diff --git a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb index 867407723..8ca1ca727 100644 --- a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb +++ b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb @@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3 S = "${WORKDIR}/git/" EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'" -CFLAGS += "${TUNE_CCARGS}" do_install () {
Default toolchain is not configured for hard float therefore we need to pass the right -mfloat-abi option Signed-off-by: Khem Raj <raj.khem@gmail.com> --- Changes in V3: Append -mfloat-abi only on armv6 meta-initramfs/classes/klibc.bbclass | 2 ++ meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.14.1 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel