[CLOUD-DEV,v3,2/11] example: l2fwd_simple: disable socket pktios

Message ID 1505358015-27878-3-git-send-email-odpbot@yandex.ru
State Superseded
Headers show
  • [CLOUD-DEV,v3,1/11] framework: modular: extern SUBSYSTEM_FOREACH_TEMPLATE
Related show

Commit Message

Github ODP bot Sept. 14, 2017, 3 a.m.
From: Yi He <yi.he@linaro.org>

l2fwd_simple_run.sh waits 1 second to allow test
application to forward more than 10 packets. It
works in case pktios are listed statically and
pcap takes precedence over socket pktios.

But with dynamically registered pktios the order
was not guaranteed and socket pktios may take
precedence over pcap pktio, which spent more time
in open operation and caused this test failed.

Disable the socket pktios since they mistakenly
take too long time in open operation, future code
refactory should solve the problem thoroughly.

Signed-off-by: Yi He <yi.he@linaro.org>

Reviewed-by: Brian Brooks <brian.brooks@arm.com>

Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Reviewed-by: Kevin Wang <kevin.wang@arm.com>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>

/** Email created from pull request 139 (heyi-linaro:modular-pktio-ops)
 ** https://github.com/Linaro/odp/pull/139
 ** Patch: https://github.com/Linaro/odp/pull/139.patch
 ** Base sha: a1f50ad720e11a54b13c4786cad4687cb5c4ec2a
 ** Merge commit sha: a25c44f448c9f01c48cfb51f6350d317baab8700
 example/l2fwd_simple/l2fwd_simple_run.sh | 5 +++++
 1 file changed, 5 insertions(+)


diff --git a/example/l2fwd_simple/l2fwd_simple_run.sh b/example/l2fwd_simple/l2fwd_simple_run.sh
index 130a3a84..0c464f70 100755
--- a/example/l2fwd_simple/l2fwd_simple_run.sh
+++ b/example/l2fwd_simple/l2fwd_simple_run.sh
@@ -6,6 +6,11 @@ 
 # SPDX-License-Identifier:     BSD-3-Clause
+# Disable socket pktios since their open operations
+# mistakenly take too long time
 PCAP_IN=`find . ${TEST_DIR} $(dirname $0) -name udp64.pcap -print -quit`
 echo "using PCAP_IN = ${PCAP_IN}"