clk: samsung: Properly propagate flags in __PLL macro

Message ID 1505399897-4840-1-git-send-email-m.szyprowski@samsung.com
State New
Headers show
Series
  • clk: samsung: Properly propagate flags in __PLL macro
Related show

Commit Message

Marek Szyprowski Sept. 14, 2017, 2:38 p.m.
All users of __PLL macro already provide flags parameter, so don't
overwrite it unconditionally with CLK_GET_RATE_NOCACHE.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 drivers/clk/samsung/clk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Chanwoo Choi Sept. 15, 2017, 2:49 a.m. | #1
On 2017년 09월 14일 23:38, Marek Szyprowski wrote:
> All users of __PLL macro already provide flags parameter, so don't

> overwrite it unconditionally with CLK_GET_RATE_NOCACHE.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  drivers/clk/samsung/clk.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h

> index b8ca0dd3a38b..d5f0d3f818b6 100644

> --- a/drivers/clk/samsung/clk.h

> +++ b/drivers/clk/samsung/clk.h

> @@ -305,7 +305,7 @@ struct samsung_pll_clock {

>  		.dev_name	= _dname,				\

>  		.name		= _name,				\

>  		.parent_name	= _pname,				\

> -		.flags		= CLK_GET_RATE_NOCACHE,			\

> +		.flags		= _flags,				\

>  		.con_offset	= _con,					\

>  		.lock_offset	= _lock,				\

>  		.rate_table	= _rtable,				\

> 


Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sylwester Nawrocki Oct. 3, 2017, 10:29 a.m. | #2
On 09/14/2017 04:38 PM, Marek Szyprowski wrote:
> All users of __PLL macro already provide flags parameter, so don't

> overwrite it unconditionally with CLK_GET_RATE_NOCACHE.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


Patch applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h
index b8ca0dd3a38b..d5f0d3f818b6 100644
--- a/drivers/clk/samsung/clk.h
+++ b/drivers/clk/samsung/clk.h
@@ -305,7 +305,7 @@  struct samsung_pll_clock {
 		.dev_name	= _dname,				\
 		.name		= _name,				\
 		.parent_name	= _pname,				\
-		.flags		= CLK_GET_RATE_NOCACHE,			\
+		.flags		= _flags,				\
 		.con_offset	= _con,					\
 		.lock_offset	= _lock,				\
 		.rate_table	= _rtable,				\