ARM: dts: exynos: Remove redundant interrupt properties in gpio-keys

Message ID 1505457767-24104-1-git-send-email-m.szyprowski@samsung.com
State New
Headers show
Series
  • ARM: dts: exynos: Remove redundant interrupt properties in gpio-keys
Related show

Commit Message

Marek Szyprowski Sept. 15, 2017, 6:42 a.m.
GPIO keys don't need interrupt property. Interrupt number can be derived
directly from the GPIO pin definition, so remove redundant 'interrupts'
and 'interrupt-parent' properties from gpio-keys nodes.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 --
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 --
 2 files changed, 4 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Krzysztof Kozlowski Sept. 19, 2017, 5:24 p.m. | #1
On Fri, Sep 15, 2017 at 08:42:47AM +0200, Marek Szyprowski wrote:
> GPIO keys don't need interrupt property. Interrupt number can be derived

> directly from the GPIO pin definition, so remove redundant 'interrupts'

> and 'interrupt-parent' properties from gpio-keys nodes.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 --

>  arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 --

>  2 files changed, 4 deletions(-)

> 


Thanks, applied with slight adjustments in title/subject about boards.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 102acd78be15..ce20f30db268 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -31,8 +31,6 @@ 
 		pinctrl-0 = <&gpio_power_key>;
 
 		power_key {
-			interrupt-parent = <&gpx1>;
-			interrupts = <3 IRQ_TYPE_NONE>;
 			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 97882267ef09..acf48a018e5e 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -43,8 +43,6 @@ 
 		pinctrl-0 = <&gpio_power_key &gpio_home_key>;
 
 		home_key {
-			interrupt-parent = <&gpx2>;
-			interrupts = <2 IRQ_TYPE_NONE>;
 			gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_HOME>;
 			label = "home key";