| Message ID | 20170915192848.649455-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 5ef288d42aefef63f728116818a097b3caf000a5 |
| Headers | show |
| Series | clk: mediatek: mark mtk_infrasys_init_early __init | expand |
On 09/15, Arnd Bergmann wrote: > On gcc-4.6, we get a harmless link-time warning: > > WARNING: vmlinux.o(.text.unlikely+0x196a0): Section mismatch in reference from the function mtk_infrasys_init_early() to the function .init.text:mtk_clk_register_cpumuxes() > The function mtk_infrasys_init_early() references > the function __init mtk_clk_register_cpumuxes(). > This is often because mtk_infrasys_init_early lacks a __init > annotation or the annotation of mtk_clk_register_cpumuxes is wrong. > > Newer compilers inline this function so they don't warn, but > marking it __init is the right solution for all versions. > > Fixes: e9862118272a ("clk: mediatek: Add MT2701 clock support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/drivers/clk/mediatek/clk-mt2701.c b/drivers/clk/mediatek/clk-mt2701.c index 9598889f972b..8e7f16fd87c9 100644 --- a/drivers/clk/mediatek/clk-mt2701.c +++ b/drivers/clk/mediatek/clk-mt2701.c @@ -750,7 +750,7 @@ static const struct mtk_fixed_factor infra_fixed_divs[] = { static struct clk_onecell_data *infra_clk_data; -static void mtk_infrasys_init_early(struct device_node *node) +static void __init mtk_infrasys_init_early(struct device_node *node) { int r, i;
On gcc-4.6, we get a harmless link-time warning: WARNING: vmlinux.o(.text.unlikely+0x196a0): Section mismatch in reference from the function mtk_infrasys_init_early() to the function .init.text:mtk_clk_register_cpumuxes() The function mtk_infrasys_init_early() references the function __init mtk_clk_register_cpumuxes(). This is often because mtk_infrasys_init_early lacks a __init annotation or the annotation of mtk_clk_register_cpumuxes is wrong. Newer compilers inline this function so they don't warn, but marking it __init is the right solution for all versions. Fixes: e9862118272a ("clk: mediatek: Add MT2701 clock support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/clk/mediatek/clk-mt2701.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0