diff mbox series

[v2] dmaengine: sun6i: use of_device_get_match_data

Message ID 20170920072402.27704-1-clabbe.montjoie@gmail.com
State Accepted
Commit 8f3b00347bf075fb457f90ce76573615f567e7bc
Headers show
Series [v2] dmaengine: sun6i: use of_device_get_match_data | expand

Commit Message

Corentin Labbe Sept. 20, 2017, 7:24 a.m. UTC 
The usage of of_device_get_match_data reduce the code size a bit.
Furthermore, it prevents an improbable dereference when
of_match_device() return NULL.

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

---
Changes since v1:
- fixed commit title
 drivers/dma/sun6i-dma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.13.5

Comments

Vinod Koul Sept. 21, 2017, 5:23 p.m. UTC | #1 
On Wed, Sep 20, 2017 at 09:24:02AM +0200, Corentin Labbe wrote:
> The usage of of_device_get_match_data reduce the code size a bit.

> Furthermore, it prevents an improbable dereference when

> of_match_device() return NULL.


Applied, thanks

-- 
~Vinod
diff mbox series

Patch

diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index bcd496edc70f..584f4e82a9be 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -1064,7 +1064,6 @@  MODULE_DEVICE_TABLE(of, sun6i_dma_match);
 
 static int sun6i_dma_probe(struct platform_device *pdev)
 {
-	const struct of_device_id *device;
 	struct sun6i_dma_dev *sdc;
 	struct resource *res;
 	int ret, i;
@@ -1073,10 +1072,9 @@  static int sun6i_dma_probe(struct platform_device *pdev)
 	if (!sdc)
 		return -ENOMEM;
 
-	device = of_match_device(sun6i_dma_match, &pdev->dev);
-	if (!device)
+	sdc->cfg = of_device_get_match_data(&pdev->dev);
+	if (!sdc->cfg)
 		return -ENODEV;
-	sdc->cfg = device->data;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	sdc->base = devm_ioremap_resource(&pdev->dev, res);