[Linaro-uefi,linaro-uefi,v2,07/11] Hisilicon/D03: remove the implemention of PerfTuning

Message ID 1505918938-52550-11-git-send-email-heyi.guo@linaro.org
State New
Headers show
Series
  • Update D03/D05 binary for edk2 update and bug fix.
Related show

Commit Message

Guo Heyi Sept. 20, 2017, 2:48 p.m.
From: Chenhui Sun <chenhui.sun@linaro.org>

The PerTuning function is not stable, it will cause the
3008/3108 crash, remove this function first.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chenhui Sun <chenhui.sun@linaro.org>
---
 Platform/Hisilicon/D03/D03.dsc | 1 -
 1 file changed, 1 deletion(-)

Comments

Leif Lindholm Sept. 20, 2017, 3:54 p.m. | #1
On Wed, Sep 20, 2017 at 10:48:54PM +0800, Heyi Guo wrote:
> From: Chenhui Sun <chenhui.sun@linaro.org>
> 
> The PerTuning function is not stable, it will cause the
> 3008/3108 crash, remove this function first.

Should this not also delete the PciPerfTuning() function from
PcieInitLib.c, and the declaration of
gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable from HisiPkg.dec?

Regards,

Leif

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chenhui Sun <chenhui.sun@linaro.org>
> ---
>  Platform/Hisilicon/D03/D03.dsc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index c47d552..33e9940 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -112,7 +112,6 @@
>    #  It could be set FALSE to save size.
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
>    gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE
> -  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE
>  
>  [PcdsFixedAtBuild.common]
>    gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03"
> -- 
> 1.9.1
>

Patch

diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index c47d552..33e9940 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -112,7 +112,6 @@ 
   #  It could be set FALSE to save size.
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
   gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE
-  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE
 
 [PcdsFixedAtBuild.common]
   gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03"