[Linaro-uefi] platforms.config: hikey: Add note for upstream atf usage

Message ID 20170921085859.14924-1-victor.chong@linaro.org
State New
Headers show
Series
  • [Linaro-uefi] platforms.config: hikey: Add note for upstream atf usage
Related show

Commit Message

Victor Chong Sept. 21, 2017, 8:58 a.m.
hikey is now supported in upstream atf, i.e.
https://github.com/ARM-software/arm-trusted-firmware

but the way the OP-TEE binary is loaded differs from
https://github.com/96boards-hikey/arm-trusted-firmware

so add a note to inform users about setting a different TOS_BIN when
using upstream atf, otherwise firmware boot will hang.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
---
 platforms.config | 3 +++
 1 file changed, 3 insertions(+)

Comments

Leif Lindholm Sept. 21, 2017, 9:26 a.m. | #1
On Thu, Sep 21, 2017 at 09:58:59AM +0100, Victor Chong wrote:
> hikey is now supported in upstream atf, i.e.
> https://github.com/ARM-software/arm-trusted-firmware
> 
> but the way the OP-TEE binary is loaded differs from
> https://github.com/96boards-hikey/arm-trusted-firmware
> 
> so add a note to inform users about setting a different TOS_BIN when
> using upstream atf, otherwise firmware boot will hang.
> 
> Signed-off-by: Victor Chong <victor.chong@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as b31fbcf.

Are you coming to Connect?
If so, we should have a chat about moving you over to edk2-platforms
from OpenPlatformPkg at some point after my talk on Tuesday.

/
    Leif

> ---
>  platforms.config | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/platforms.config b/platforms.config
> index 6d3abff..deb02f4 100644
> --- a/platforms.config
> +++ b/platforms.config
> @@ -194,6 +194,9 @@ PACKAGES_PATH=OpenPlatformPkg/Platforms/AMD/Styx/Binary
>  UEFI_BIN=STYX_ROM.fd
>  UEFI_IMAGE_DIR=Cello
>  
> +# NOTE: If using upstream ATF, i.e.
> +# https://github.com/ARM-software/arm-trusted-firmware
> +# please set TOS_BIN=tee-pager.bin
>  [hikey]
>  LONGNAME=CircuitCo HiKey
>  DSC=OpenPlatformPkg/Platforms/Hisilicon/HiKey/HiKey.dsc
> -- 
> 2.13.0
>

Patch

diff --git a/platforms.config b/platforms.config
index 6d3abff..deb02f4 100644
--- a/platforms.config
+++ b/platforms.config
@@ -194,6 +194,9 @@  PACKAGES_PATH=OpenPlatformPkg/Platforms/AMD/Styx/Binary
 UEFI_BIN=STYX_ROM.fd
 UEFI_IMAGE_DIR=Cello
 
+# NOTE: If using upstream ATF, i.e.
+# https://github.com/ARM-software/arm-trusted-firmware
+# please set TOS_BIN=tee-pager.bin
 [hikey]
 LONGNAME=CircuitCo HiKey
 DSC=OpenPlatformPkg/Platforms/Hisilicon/HiKey/HiKey.dsc