[3/3] acpi : remove pointless variable initialization

Message ID 1347614736-9553-3-git-send-email-daniel.lezcano@linaro.org
State Accepted
Commit ed1511b80c92b1b1a8dde567adc090e470a4344a
Headers show

Commit Message

Daniel Lezcano Sept. 14, 2012, 9:25 a.m.
The 'errata' variable is a global variable which is set to zero,
no need to do that with a memset in the init function.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/acpi/processor_driver.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Rafael J. Wysocki Sept. 15, 2012, 8:56 p.m. | #1
On Friday, September 14, 2012, Daniel Lezcano wrote:
> The 'errata' variable is a global variable which is set to zero,
> no need to do that with a memset in the init function.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Applied to the linux-next branch of the linux-pm.git tree as v3.7 material.

Thanks,
Rafael


> ---
>  drivers/acpi/processor_driver.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
> index 9c9288b..e78c2a5 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -905,8 +905,6 @@ static int __init acpi_processor_init(void)
>  	if (acpi_disabled)
>  		return 0;
>  
> -	memset(&errata, 0, sizeof(errata));
> -
>  	result = acpi_bus_register_driver(&acpi_processor_driver);
>  	if (result < 0)
>  		return result;
>

Patch

diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index 9c9288b..e78c2a5 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -905,8 +905,6 @@  static int __init acpi_processor_init(void)
 	if (acpi_disabled)
 		return 0;
 
-	memset(&errata, 0, sizeof(errata));
-
 	result = acpi_bus_register_driver(&acpi_processor_driver);
 	if (result < 0)
 		return result;