[v2,07/10] mfd: axp20x: add pinctrl cell for AXP813

Message ID 5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com
State New
Headers show
Series
  • add pinmuxing support for pins in AXP209 and AXP813 PMICs
Related show

Commit Message

Quentin Schulz Sept. 26, 2017, 12:17 p.m.
As pinctrl and GPIO driver now supports AXP813, add a cell for it.

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

---
 drivers/mfd/axp20x.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
git-series 0.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Maxime Ripard Sept. 26, 2017, 1:14 p.m. | #1
On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote:
> As pinctrl and GPIO driver now supports AXP813, add a cell for it.

> 

> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

> ---

>  drivers/mfd/axp20x.c | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c

> index 336de66..a457528 100644

> --- a/drivers/mfd/axp20x.c

> +++ b/drivers/mfd/axp20x.c

> @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = {

>  		.name			= "axp221-pek",

>  		.num_resources		= ARRAY_SIZE(axp803_pek_resources),

>  		.resources		= axp803_pek_resources,

> +	}, {

> +		.name			= "axp20x-gpio",

> +		.of_compatible		= "x-powers,axp813-pctl",


This was probably introduced in the previous driver, but why are you
using the pctl suffix? Can't we just use the GPIO one to remain
consistent with the previous users and the datasheet?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Lee Jones Sept. 28, 2017, 7:06 p.m. | #2
On Tue, 26 Sep 2017, Maxime Ripard wrote:

> On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote:

> > As pinctrl and GPIO driver now supports AXP813, add a cell for it.

> > 

> > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

> > ---

> >  drivers/mfd/axp20x.c | 3 +++

> >  1 file changed, 3 insertions(+)

> > 

> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c

> > index 336de66..a457528 100644

> > --- a/drivers/mfd/axp20x.c

> > +++ b/drivers/mfd/axp20x.c

> > @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = {

> >  		.name			= "axp221-pek",

> >  		.num_resources		= ARRAY_SIZE(axp803_pek_resources),

> >  		.resources		= axp803_pek_resources,

> > +	}, {

> > +		.name			= "axp20x-gpio",

> > +		.of_compatible		= "x-powers,axp813-pctl",

> 

> This was probably introduced in the previous driver, but why are you

> using the pctl suffix? Can't we just use the GPIO one to remain

> consistent with the previous users and the datasheet?


Right.  Pinctrl is a Linuxisum.  GPIO sounds more appropriate.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 336de66..a457528 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -876,6 +876,9 @@  static struct mfd_cell axp813_cells[] = {
 		.name			= "axp221-pek",
 		.num_resources		= ARRAY_SIZE(axp803_pek_resources),
 		.resources		= axp803_pek_resources,
+	}, {
+		.name			= "axp20x-gpio",
+		.of_compatible		= "x-powers,axp813-pctl",
 	}
 };