[ARM,testsuite] Some tests require arm_neon_hw

Message ID CAKdteOZWJmSdsSQpAKgpQa0A5SjVy++qdnXT+g0TKFJrQe_cww@mail.gmail.com
State New
Headers show
Series
  • [ARM,testsuite] Some tests require arm_neon_hw
Related show

Commit Message

Christophe Lyon Sept. 28, 2017, 1:09 p.m.
Hi,

I've noticed that a few dg-run arm tests require Neon to execute, but
do not ensure that. They only check that the compiler options are
support. This small patch fixes that by adding arm_neon_hw
effective-target.

This makes the tests unsupported on the related configurations (eg
cortex-m3 , arm10tdmi).

OK?

Thanks,

Christophe
2017-09-28  Christophe Lyon  <christophe.lyon@linaro.org>

	* gcc.target/arm/aapcs/align4.c: Require arm_neon_hw effective target.
	* gcc.target/arm/aapcs/align_rec4.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect1.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect2.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect3.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect4.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect5.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect6.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect7.c: Likewise.
	* gcc.target/arm/aapcs/neon-vect8.c: Likewise.

Comments

Richard Earnshaw Sept. 28, 2017, 1:47 p.m. | #1
On 28/09/17 14:09, Christophe Lyon wrote:
> Hi,

> 

> I've noticed that a few dg-run arm tests require Neon to execute, but

> do not ensure that. They only check that the compiler options are

> support. This small patch fixes that by adding arm_neon_hw

> effective-target.

> 

> This makes the tests unsupported on the related configurations (eg

> cortex-m3 , arm10tdmi).

> 

> OK?

> 

> Thanks,

> 

> Christophe

> 


OK.

R.

Patch

diff --git a/gcc/testsuite/gcc.target/arm/aapcs/align4.c b/gcc/testsuite/gcc.target/arm/aapcs/align4.c
index 5535c55..df52335 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/align4.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/align4.c
@@ -2,7 +2,8 @@ 
 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm32 } */
-/* { dg-require-effective-target arm_neon_ok  } */
+/* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-options "-O" } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/align_rec4.c b/gcc/testsuite/gcc.target/arm/aapcs/align_rec4.c
index 907b90a..6732fa6 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/align_rec4.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/align_rec4.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-options "-O -fno-inline" } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect1.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect1.c
index 64f9466..1a85761 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect1.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect1.c
@@ -1,8 +1,9 @@ 
 /* Test AAPCS layout (VFP variant for Neon types) */
 
 /* { dg-do run { target arm_eabi } } */
-/* { dg-require-effective-target arm_hard_vfp_ok  } */
-/* { dg-require-effective-target arm_neon_ok  } */
+/* { dg-require-effective-target arm_hard_vfp_ok } */
+/* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect2.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect2.c
index f5d4609..66d73ce 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect2.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect2.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect3.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect3.c
index 31fb1da..38c04ab 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect3.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect3.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect4.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect4.c
index bfefccc..1e6a0a5 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect4.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect4.c
@@ -1,8 +1,9 @@ 
 /* Test AAPCS layout (VFP variant for Neon types) */
 
 /* { dg-do run { target arm_eabi } } */
-/* { dg-require-effective-target arm_hard_vfp_ok  } */
+/* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect5.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect5.c
index ff7a857..fd78be2 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect5.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect5.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect6.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect6.c
index b952e5d..e5a022b 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect6.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect6.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect7.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect7.c
index 782f3a6..de021ef 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect7.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect7.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */
 
diff --git a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect8.c b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect8.c
index 578a3d3..9eb81a8 100644
--- a/gcc/testsuite/gcc.target/arm/aapcs/neon-vect8.c
+++ b/gcc/testsuite/gcc.target/arm/aapcs/neon-vect8.c
@@ -3,6 +3,7 @@ 
 /* { dg-do run { target arm_eabi } } */
 /* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_neon_hw } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-add-options arm_neon } */