DT/arm,gic-v3: Update the ITS size in the examples

Message ID 20171003142027.23243-1-julien.grall@linaro.org
State Accepted
Commit 4a40aedec653bb9e22c01ef4fe0a66278b1a666f
Headers show
Series
  • DT/arm,gic-v3: Update the ITS size in the examples
Related show

Commit Message

Julien Grall Oct. 3, 2017, 2:20 p.m.
Currently, the examples are using 2MB for the ITS size. Per the
specification (section 8.18 in ARM IHI 0069D), the ITS address map is
128KB.

Update the examples to match the specification.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---
 .../devicetree/bindings/interrupt-controller/arm,gic-v3.txt         | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mark Rutland Oct. 3, 2017, 2:53 p.m. | #1
On Tue, Oct 03, 2017 at 03:20:27PM +0100, Julien Grall wrote:
> Currently, the examples are using 2MB for the ITS size. Per the

> specification (section 8.18 in ARM IHI 0069D), the ITS address map is

> 128KB.

> 

> Update the examples to match the specification.

> 

> Signed-off-by: Julien Grall <julien.grall@linaro.org>


This looks sane to me, per my reading of that section of the spec.

Marc, was there some reason we used such a large size? Or was the extra
zero unintentional?

Thanks,
Mark.

> ---

>  .../devicetree/bindings/interrupt-controller/arm,gic-v3.txt         | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt

> index 4c29cdab0ea5..5eb108e180fa 100644

> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt

> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt

> @@ -99,7 +99,7 @@ Examples:

>  			compatible = "arm,gic-v3-its";

>  			msi-controller;

>  			#msi-cells = <1>;

> -			reg = <0x0 0x2c200000 0 0x200000>;

> +			reg = <0x0 0x2c200000 0 0x20000>;

>  		};

>  	};

>  

> @@ -124,14 +124,14 @@ Examples:

>  			compatible = "arm,gic-v3-its";

>  			msi-controller;

>  			#msi-cells = <1>;

> -			reg = <0x0 0x2c200000 0 0x200000>;

> +			reg = <0x0 0x2c200000 0 0x20000>;

>  		};

>  

>  		gic-its@2c400000 {

>  			compatible = "arm,gic-v3-its";

>  			msi-controller;

>  			#msi-cells = <1>;

> -			reg = <0x0 0x2c400000 0 0x200000>;

> +			reg = <0x0 0x2c400000 0 0x20000>;

>  		};

>  

>  		ppi-partitions {

> -- 

> 2.11.0

> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marc Zyngier Oct. 3, 2017, 3:03 p.m. | #2
On 03/10/17 15:53, Mark Rutland wrote:
> On Tue, Oct 03, 2017 at 03:20:27PM +0100, Julien Grall wrote:

>> Currently, the examples are using 2MB for the ITS size. Per the

>> specification (section 8.18 in ARM IHI 0069D), the ITS address map is

>> 128KB.

>>

>> Update the examples to match the specification.

>>

>> Signed-off-by: Julien Grall <julien.grall@linaro.org>

> 

> This looks sane to me, per my reading of that section of the spec.

> 

> Marc, was there some reason we used such a large size? Or was the extra

> zero unintentional?


It is just that counting zeroes is hard. I usually just type a bunch of
them and let careful people sort it out. ;-)

I'll apply that as a fix.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
index 4c29cdab0ea5..5eb108e180fa 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
@@ -99,7 +99,7 @@  Examples:
 			compatible = "arm,gic-v3-its";
 			msi-controller;
 			#msi-cells = <1>;
-			reg = <0x0 0x2c200000 0 0x200000>;
+			reg = <0x0 0x2c200000 0 0x20000>;
 		};
 	};
 
@@ -124,14 +124,14 @@  Examples:
 			compatible = "arm,gic-v3-its";
 			msi-controller;
 			#msi-cells = <1>;
-			reg = <0x0 0x2c200000 0 0x200000>;
+			reg = <0x0 0x2c200000 0 0x20000>;
 		};
 
 		gic-its@2c400000 {
 			compatible = "arm,gic-v3-its";
 			msi-controller;
 			#msi-cells = <1>;
-			reg = <0x0 0x2c400000 0 0x200000>;
+			reg = <0x0 0x2c400000 0 0x20000>;
 		};
 
 		ppi-partitions {