From patchwork Wed Oct 4 18:20:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 114792 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3431551qgn; Wed, 4 Oct 2017 11:20:47 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBULBXtZB5DtYg5j9MVAEgfYGsAPSkc4PcuI9U4uA0pYeoUYHlfsP8khAvzTh6GbPGan9U+ X-Received: by 10.99.116.22 with SMTP id p22mr11591113pgc.372.1507141247603; Wed, 04 Oct 2017 11:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507141247; cv=none; d=google.com; s=arc-20160816; b=tY/0au2wOkTLXY+Syt/s1va0ynwePu+M5bqCqmpCKzK2XUw9L+fVvP8I1H6uIgiOUf +unTP7tewYqpClV7Hnll9l+BYstsRsUK5L8aV400/eUyUFrmxUxcZtyICXkIwHgqJ+O0 ssIX+6JOV+rXBEEBOsMM/YXpVPjERyx0UqRwj4E7tQvGF7P1c/cfLKK/oA8NU3BzPPjw z+Qb/b1wxG4mZ8LqJhsEOimRpKxANnIbFy9eWC8T02NPzXVi3aiI+0kChePOviae0CdK mHXnAi4GCmj9j1GfccUkGtVyI3AAcPZeciJl4VgwohQE4frXYXuVpUPfaSOmUy3+xa5G GxtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=03gVwUbfxTL2/9dZChX+jg1dASSgXvt3FHiAAnP1G5k=; b=CgBnUXY8RLW4xCtSJxQY+78pliCsRKb521fUIe5k9oEJQ9ej4qzBKlGerf4zchQP11 eacZdWCG4rgHRYKESaJ0KCGqi/P22jhY1ogYMWDLdI4Z8ZlciP9sj0JEeOdvfhNx2Hmq y+dTGbhKoX5toJJRw7sS9+KOy6KCxMpyGF3KpYK2FpAfV79eEBFFjeK8mu76Ye6Tki+j qMnjr+VeYgtFkxpYf8XBX1k0YMjt/0rybGEYY9bfbMc28q+U7cX6ZBZv/9T/lKvxDy11 lmMHcTBD3nGHr855NA/ZnMLwPEPRR1Ifu3GVffBnZMCU+ExDnMHC1y88rnAYcJs7YOsb Bmcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=xcpB+m8P; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10si11851167pgs.45.2017.10.04.11.20.47; Wed, 04 Oct 2017 11:20:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=xcpB+m8P; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbdJDSUp (ORCPT + 8 others); Wed, 4 Oct 2017 14:20:45 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:24915 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdJDSUn (ORCPT ); Wed, 4 Oct 2017 14:20:43 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v94IKYTm022063; Wed, 4 Oct 2017 13:20:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1507141234; bh=beT55en7Sn46HAtoh4o4Y4W7jG9B4jLy0LYw+S5i51I=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=xcpB+m8PUaTJNcbv6MTYZWiBwd/QOzz+pGP/JIT8boCzKW0VQ54M7WnEB88VFfzx6 UzBKKyPFil9L5Mr3SEQ6YT/7Jrpmf0UfrPYba7Va7kTM7BThWhNXsxqaa3YrdoIhGG aqXrX27rcJcs9/yksedItiiRHykbSoLpPogWaeHU= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v94IKYTR024020; Wed, 4 Oct 2017 13:20:34 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 4 Oct 2017 13:20:34 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Wed, 4 Oct 2017 13:20:34 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v94IKYJ0004069; Wed, 4 Oct 2017 13:20:34 -0500 Received: from localhost ([172.22.138.27]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id v94IKY315971; Wed, 4 Oct 2017 13:20:34 -0500 (CDT) From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH 3/3 v2] net: phy: Change error to EINVAL for invalid MAC Date: Wed, 4 Oct 2017 13:20:31 -0500 Message-ID: <20171004182031.13794-3-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20171004182031.13794-1-dmurphy@ti.com> References: <20171004182031.13794-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Change the return error code to EINVAL if the MAC address is not valid in the set_wol function. Signed-off-by: Dan Murphy --- v2 - There was no v1 on this patch this is new. drivers/net/phy/at803x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.0 diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index c1e52b9dc58d..5f93e6add563 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -167,7 +167,7 @@ static int at803x_set_wol(struct phy_device *phydev, mac = (const u8 *) ndev->dev_addr; if (!is_valid_ether_addr(mac)) - return -EFAULT; + return -EINVAL; for (i = 0; i < 3; i++) { phy_write(phydev, AT803X_MMD_ACCESS_CONTROL,