diff mbox series

drm/omap: displays: panel-dpi: add backlight dependency

Message ID 20171005120651.376485-1-arnd@arndb.de
State Accepted
Commit 499ec0ed5eb2f6a7fcaab2dd66ffc5993484bda9
Headers show
Series drm/omap: displays: panel-dpi: add backlight dependency | expand

Commit Message

Arnd Bergmann Oct. 5, 2017, 12:06 p.m. UTC
The new backlight code causes a link failure when backlight
support itself is disabled:

drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'

This adds a Kconfig dependency like we have for the other OMAP
display targets.

Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0

Comments

Tomi Valkeinen Oct. 12, 2017, 8:05 a.m. UTC | #1

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 05/10/17 15:06, Arnd Bergmann wrote:
> The new backlight code causes a link failure when backlight

> support itself is disabled:

> 

> drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':

> panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'

> 

> This adds a Kconfig dependency like we have for the other OMAP

> display targets.

> 

> Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig

> index c226da145fb3..a349cb61961e 100644

> --- a/drivers/gpu/drm/omapdrm/displays/Kconfig

> +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig

> @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV

>  

>  config DRM_OMAP_PANEL_DPI

>  	tristate "Generic DPI panel"

> +	depends on BACKLIGHT_CLASS_DEVICE

>  	help

>  	  Driver for generic DPI panels.


Thanks, I've queued this for 4.14 fixes.

 Tomi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
index c226da145fb3..a349cb61961e 100644
--- a/drivers/gpu/drm/omapdrm/displays/Kconfig
+++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
@@ -35,6 +35,7 @@  config DRM_OMAP_CONNECTOR_ANALOG_TV
 
 config DRM_OMAP_PANEL_DPI
 	tristate "Generic DPI panel"
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Driver for generic DPI panels.