[2/6] of: remove struct property.unique_id for FDT

Message ID 20171005194422.26224-3-robh@kernel.org
State New
Headers show
Series
  • Untitled series #4690
Related show

Commit Message

Rob Herring Oct. 5, 2017, 7:44 p.m.
Only Sparc uses unique_id, so remove it for FDT builds and shrink struct
property a bit making the unflattened DT less of a memory hog.

Cc: Nicolas Pitre <nico@linaro.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>

---
 include/linux/of.h | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.11.0

Comments

Grant Likely Oct. 6, 2017, 1:30 p.m. | #1
On Thu, Oct 5, 2017 at 8:44 PM, Rob Herring <robh@kernel.org> wrote:
> Only Sparc uses unique_id, so remove it for FDT builds and shrink struct

> property a bit making the unflattened DT less of a memory hog.


It can be even more constrained than that. I think the only user is
openpromfs so you could make it depend on CONFIG_SUN_OPENPROMFS, and
adjust the needed code in pdt.c.

Ideally, I'd like to be rid of unique_id entirely, but that's a much
more invasive patch set. Regardless:

Acked-by: Grant Likely <grant.likely@secretlab.ca>


(That goes for the entire series)

>

> Cc: Nicolas Pitre <nico@linaro.org>

> Cc: Frank Rowand <frowand.list@gmail.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  include/linux/of.h | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/include/linux/of.h b/include/linux/of.h

> index cfc34117fc92..8f9e96752837 100644

> --- a/include/linux/of.h

> +++ b/include/linux/of.h

> @@ -38,7 +38,9 @@ struct property {

>         void    *value;

>         struct property *next;

>         unsigned long _flags;

> +#if defined(CONFIG_OF_PROMTREE)

>         unsigned int unique_id;

> +#endif

>         struct bin_attribute attr;

>  };

>

> --

> 2.11.0

>

Patch

diff --git a/include/linux/of.h b/include/linux/of.h
index cfc34117fc92..8f9e96752837 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -38,7 +38,9 @@  struct property {
 	void	*value;
 	struct property *next;
 	unsigned long _flags;
+#if defined(CONFIG_OF_PROMTREE)
 	unsigned int unique_id;
+#endif
 	struct bin_attribute attr;
 };