[06/10] binutils: Convert SRC_URI and SRCREV to weak defines

Message ID 1231bf23c001d44632edf9061b87ac6629d2fc83.1507250774.git.raj.khem@gmail.com
State Superseded
Headers show
Series
  • Add foundation for riscv architecture
Related show

Commit Message

Khem Raj Oct. 6, 2017, 12:50 a.m.
This makes it easy to override them in bbappends

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-devtools/binutils/binutils-2.29.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.14.2

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Burton, Ross Oct. 6, 2017, 10:22 a.m. | #1
On 6 October 2017 at 01:50, Khem Raj <raj.khem@gmail.com> wrote:

> This makes it easy to override them in bbappends

>


Doesn't a straight forward assignment work in a bbappend?

Ross
<div dir="ltr">On 6 October 2017 at 01:50, Khem Raj <span dir="ltr">&lt;<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt;</span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This makes it easy to override them in bbappends<br></blockquote><div><br></div><div>Doesn&#39;t a straight forward assignment work in a bbappend?</div><div><br></div><div>RossĀ </div></div></div></div>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Oct. 6, 2017, 1:23 p.m. | #2
On Fri, Oct 6, 2017 at 3:22 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 6 October 2017 at 01:50, Khem Raj <raj.khem@gmail.com> wrote:

>>

>> This makes it easy to override them in bbappends

>

>

> Doesn't a straight forward assignment work in a bbappend?

>


It doesnt work for rhe case when just git location is desired to be changed
and we still need to apply the patches from oe-core.

> Ross

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/binutils/binutils-2.29.inc b/meta/recipes-devtools/binutils/binutils-2.29.inc
index 27d46eb088..35f76cba6d 100644
--- a/meta/recipes-devtools/binutils/binutils-2.29.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.29.inc
@@ -18,9 +18,10 @@  BINUPV = "${@binutils_branch_version(d)}"
 
 UPSTREAM_CHECK_GITTAGREGEX = "binutils-(?P<pver>\d+_(\d_?)*)"
 
-SRCREV = "37e991bb143ca2106330bcdc625590d53838b7a1"
+SRCREV ?= "37e991bb143ca2106330bcdc625590d53838b7a1"
+BINUTILS_GIT_URI ?= "git://sourceware.org/git/binutils-gdb.git;branch=binutils-${BINUPV}-branch;protocol=git"
 SRC_URI = "\
-     git://sourceware.org/git/binutils-gdb.git;branch=binutils-${BINUPV}-branch;protocol=git \
+     ${BINUTILS_GIT_URI} \
      file://0003-configure-widen-the-regexp-for-SH-architectures.patch \
      file://0004-Point-scripts-location-to-libdir.patch \
      file://0005-Only-generate-an-RPATH-entry-if-LD_RUN_PATH-is-not-e.patch \