diff mbox series

[v2] iso: Reduce verbosity on test and info calls

Message ID 20171006113507.81996-1-agraf@suse.de
State Accepted
Commit b16339e254371b2823f48186889775b90b044f7e
Headers show
Series [v2] iso: Reduce verbosity on test and info calls | expand

Commit Message

Alexander Graf Oct. 6, 2017, 11:35 a.m. UTC
The test and info callbacks into the partition callback struct are
used by the "part list" command on the command line. That command
is used by the distro script.

With verb=1 set, "part list" thus throws a lot of warnings about
partitions it can't find when an upper layer searches for partitions.

So let's reduce verbosity to bring it to the same level of noise
as the other partition targets.

Signed-off-by: Alexander Graf <agraf@suse.de>

---

v1 -> v2:

  - Also silence the info callback
---
 disk/part_iso.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini Oct. 17, 2017, 12:46 a.m. UTC | #1
On Fri, Oct 06, 2017 at 01:35:07PM +0200, Alexander Graf wrote:

> The test and info callbacks into the partition callback struct are

> used by the "part list" command on the command line. That command

> is used by the distro script.

> 

> With verb=1 set, "part list" thus throws a lot of warnings about

> partitions it can't find when an upper layer searches for partitions.

> 

> So let's reduce verbosity to bring it to the same level of noise

> as the other partition targets.

> 

> Signed-off-by: Alexander Graf <agraf@suse.de>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox series

Patch

diff --git a/disk/part_iso.c b/disk/part_iso.c
index 8aef251f4e..4036b00b25 100644
--- a/disk/part_iso.c
+++ b/disk/part_iso.c
@@ -202,7 +202,7 @@  found:
 static int part_get_info_iso(struct blk_desc *dev_desc, int part_num,
 				  disk_partition_t *info)
 {
-	return part_get_info_iso_verb(dev_desc, part_num, info, 1);
+	return part_get_info_iso_verb(dev_desc, part_num, info, 0);
 }
 
 static void part_print_iso(struct blk_desc *dev_desc)
@@ -228,7 +228,7 @@  static int part_test_iso(struct blk_desc *dev_desc)
 {
 	disk_partition_t info;
 
-	return part_get_info_iso_verb(dev_desc, 1, &info, 1);
+	return part_get_info_iso_verb(dev_desc, 1, &info, 0);
 }
 
 U_BOOT_PART_TYPE(iso) = {