Message ID | 1507305585-20608-11-git-send-email-peter.maydell@linaro.org |
---|---|
State | Accepted |
Commit | cb484f9a6e790205e69d9a444c3e353a3a1cfd84 |
Headers | show
Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp1982048qgn; Fri, 6 Oct 2017 09:26:58 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCSfSOGKXT/ew47wl0iqIBmqrwqwxGcSuei7x8+9Yxhn501kDJAbYgRnvgmR6TdBt8toYvQ X-Received: by 10.55.10.18 with SMTP id 18mr20011204qkk.184.1507307218690; Fri, 06 Oct 2017 09:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507307218; cv=none; d=google.com; s=arc-20160816; b=jP5YQsbDOMN5d0+64Q1xHGXhO3EN8ySvU9mZTPFeAXF/pbQBjR/+NaI/BA7jcuopdU rVcy+4As9pE/XbwGKBIVH9LnO2UJAUXZYS5fBSpkEkuqSScBgBFTrAL158zpyy2j3WZk QOpzmPv9T83wpcyqLEIrYhTmyQDfjCJ1klBx6OWLF+EEumvfpjY2TfVCldD6kxyPut0x tdKEnGKZPuiJgKt2cbP2ZVKGxEQx12dyTEXjSaZFlTvkKdMt7wDxcpldW7A+1nK/Xnsi 1jovplloXzMbVEtqrjl6swwYnNvGB64KJzEECnrNWFt4Txco3Qf0amCx6L/mvj57FfaO NY3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=uGntMuov0PXQ1HWhpiROJ6BqNkjhi1zN40D065L8AeA=; b=SCC0E18LTQLKFE86srNL2i4MjxyrxVLPrArcwvIJRc/VVmQEoCusrDYFrJQvO3Ijse jWZuDLG3p99oK8R6RemoSNf8q+oxL5RuTEIwpdo3yaHhhGCLFR1hX8bzbH++xfOMaR/t LVtPaFi/Nz+4b0xjt3dcez4/gfjQyw3nYHgN0oobhCJl/G92q1WDBsIc9q6/7yVHYjKC Gub/g8QsmHVz2QOuMpkgHBV2OIRRP78h5F24pgHndimC9CdbFfsem2f2YZGwQOUR/9Fw ten1Z/TCfVKjlbYo9pWi403h8h0WfxTSBpYI/6Xai5zHLO4BCXdE2JbueARwZ+YbRx2B PJ5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u53si1554175qte.379.2017.10.06.09.26.58 for <patch@linaro.org> (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 06 Oct 2017 09:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+patch=linaro.org@nongnu.org>) id 1e0VSk-0003Eg-5Y for patch@linaro.org; Fri, 06 Oct 2017 12:26:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1e0V1k-0004B1-A5 for qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1e0V1j-0007o0-Js for qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:59:04 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:37716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1e0V1j-0007kt-Cf for qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:59:03 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from <pm215@archaic.org.uk>) id 1e0V1d-0002vL-JO for qemu-devel@nongnu.org; Fri, 06 Oct 2017 16:58:57 +0100 From: Peter Maydell <peter.maydell@linaro.org> To: qemu-devel@nongnu.org Date: Fri, 6 Oct 2017 16:59:35 +0100 Message-Id: <1507305585-20608-11-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507305585-20608-1-git-send-email-peter.maydell@linaro.org> References: <1507305585-20608-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 10/20] target/arm: Warn about restoring to unaligned stack X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org> |
Series |
target-arm queue
|
expand
|
diff --git a/target/arm/helper.c b/target/arm/helper.c index bee0f5d..bb57be7 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6413,6 +6413,13 @@ static void do_v7m_exception_exit(ARMCPU *cpu) return_to_sp_process); uint32_t frameptr = *frame_sp_p; + if (!QEMU_IS_ALIGNED(frameptr, 8) && + arm_feature(env, ARM_FEATURE_V8)) { + qemu_log_mask(LOG_GUEST_ERROR, + "M profile exception return with non-8-aligned SP " + "for destination state is UNPREDICTABLE\n"); + } + /* Pop registers. TODO: make these accesses use the correct * attributes and address space (S/NS, priv/unpriv) and handle * memory transaction failures.