| Message ID | 1507454252-13770-1-git-send-email-hemant.agrawal@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | igb_uio: remove compilation warning on arm64 kernel | expand |
On Sunday 08 October 2017 02:47 PM, Hemant Agrawal wrote: > IGB_UIO compilation recently got enabled for ARM64 by default > > The igb_uio compilation against ARM64 based stock 4.x (e.g. 4.13) > kernel is giving compilation warnings: > > igb_uio.c: In function ‘igbuio_pci_irqcontrol’: > igb_uio.c:115:25: error: implicit declaration of function > ‘irq_get_irq_dat ’ [-Werror=implicit-function-declaration] > struct irq_data *irq = irq_get_irq_data(udev->info.irq); > ^ > igb_uio.c:115:25: error: initialization makes pointer from integer without > a cast [-Werror=int-conversion] > > Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X") > Cc: stable@dpdk.org > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- Breaks thunderx too. Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> and Tested-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> Thanks.
08/10/2017 12:59, santosh: > > On Sunday 08 October 2017 02:47 PM, Hemant Agrawal wrote: > > IGB_UIO compilation recently got enabled for ARM64 by default > > > > The igb_uio compilation against ARM64 based stock 4.x (e.g. 4.13) > > kernel is giving compilation warnings: > > > > igb_uio.c: In function ‘igbuio_pci_irqcontrol’: > > igb_uio.c:115:25: error: implicit declaration of function > > ‘irq_get_irq_dat ’ [-Werror=implicit-function-declaration] > > struct irq_data *irq = irq_get_irq_data(udev->info.irq); > > ^ > > igb_uio.c:115:25: error: initialization makes pointer from integer without > > a cast [-Werror=int-conversion] > > > > Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X") > > Cc: stable@dpdk.org > > > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > > --- > > Breaks thunderx too. > > Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> > and > Tested-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> Applied, thanks
diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index a440924..da71e05 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -29,6 +29,7 @@ #include <linux/pci.h> #include <linux/uio_driver.h> #include <linux/io.h> +#include <linux/irq.h> #include <linux/msi.h> #include <linux/version.h> #include <linux/slab.h>
IGB_UIO compilation recently got enabled for ARM64 by default The igb_uio compilation against ARM64 based stock 4.x (e.g. 4.13) kernel is giving compilation warnings: igb_uio.c: In function ‘igbuio_pci_irqcontrol’: igb_uio.c:115:25: error: implicit declaration of function ‘irq_get_irq_dat ’ [-Werror=implicit-function-declaration] struct irq_data *irq = irq_get_irq_data(udev->info.irq); ^ igb_uio.c:115:25: error: initialization makes pointer from integer without a cast [-Werror=int-conversion] Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4