clk: samsung: exynos5433: mark PM functions as __maybe_unused

Message ID 20171010091522.2286344-1-arnd@arndb.de
State New
Headers show
Series
  • clk: samsung: exynos5433: mark PM functions as __maybe_unused
Related show

Commit Message

Arnd Bergmann Oct. 10, 2017, 9:15 a.m.
The suspend/resume functions are referenced conditionally, causing
a harmless warning when CONFIG_PM is disabled:

drivers/clk/samsung/clk-exynos5433.c:5476:12: error: 'exynos5433_cmu_resume' defined but not used [-Werror=unused-function]
drivers/clk/samsung/clk-exynos5433.c:5453:12: error: 'exynos5433_cmu_suspend' defined but not used [-Werror=unused-function]

This marks both as __maybe_unused to shut up the warning.

Fixes: 523d3de41f02 ("clk: samsung: exynos5433: Add support for runtime PM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/clk/samsung/clk-exynos5433.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Marek Szyprowski Oct. 10, 2017, 9:30 a.m. | #1
Hi Arnd,

On 2017-10-10 11:15, Arnd Bergmann wrote:
> The suspend/resume functions are referenced conditionally, causing

> a harmless warning when CONFIG_PM is disabled:

>

> drivers/clk/samsung/clk-exynos5433.c:5476:12: error: 'exynos5433_cmu_resume' defined but not used [-Werror=unused-function]

> drivers/clk/samsung/clk-exynos5433.c:5453:12: error: 'exynos5433_cmu_suspend' defined but not used [-Werror=unused-function]

>

> This marks both as __maybe_unused to shut up the warning.

>

> Fixes: 523d3de41f02 ("clk: samsung: exynos5433: Add support for runtime PM")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>


> ---

>   drivers/clk/samsung/clk-exynos5433.c | 4 ++--

>   1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c

> index cd9337613dd8..db270908037a 100644

> --- a/drivers/clk/samsung/clk-exynos5433.c

> +++ b/drivers/clk/samsung/clk-exynos5433.c

> @@ -5450,7 +5450,7 @@ struct exynos5433_cmu_data {

>   	struct samsung_clk_provider ctx;

>   };

>   

> -static int exynos5433_cmu_suspend(struct device *dev)

> +static int __maybe_unused exynos5433_cmu_suspend(struct device *dev)

>   {

>   	struct exynos5433_cmu_data *data = dev_get_drvdata(dev);

>   	int i;

> @@ -5473,7 +5473,7 @@ static int exynos5433_cmu_suspend(struct device *dev)

>   	return 0;

>   }

>   

> -static int exynos5433_cmu_resume(struct device *dev)

> +static int __maybe_unused exynos5433_cmu_resume(struct device *dev)

>   {

>   	struct exynos5433_cmu_data *data = dev_get_drvdata(dev);

>   	int i;


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ulf Hansson Oct. 10, 2017, 10:41 a.m. | #2
On 10 October 2017 at 11:15, Arnd Bergmann <arnd@arndb.de> wrote:
> The suspend/resume functions are referenced conditionally, causing

> a harmless warning when CONFIG_PM is disabled:

>

> drivers/clk/samsung/clk-exynos5433.c:5476:12: error: 'exynos5433_cmu_resume' defined but not used [-Werror=unused-function]

> drivers/clk/samsung/clk-exynos5433.c:5453:12: error: 'exynos5433_cmu_suspend' defined but not used [-Werror=unused-function]

>

> This marks both as __maybe_unused to shut up the warning.

>

> Fixes: 523d3de41f02 ("clk: samsung: exynos5433: Add support for runtime PM")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


FWIW:

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>


[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sylwester Nawrocki Oct. 11, 2017, 9:07 a.m. | #3
On 10/10/2017 11:15 AM, Arnd Bergmann wrote:
> The suspend/resume functions are referenced conditionally, causing

> a harmless warning when CONFIG_PM is disabled:

> 

> drivers/clk/samsung/clk-exynos5433.c:5476:12: error: 'exynos5433_cmu_resume' defined but not used [-Werror=unused-function]

> drivers/clk/samsung/clk-exynos5433.c:5453:12: error: 'exynos5433_cmu_suspend' defined but not used [-Werror=unused-function]

> 

> This marks both as __maybe_unused to shut up the warning.

> 

> Fixes: 523d3de41f02 ("clk: samsung: exynos5433: Add support for runtime PM")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index cd9337613dd8..db270908037a 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -5450,7 +5450,7 @@  struct exynos5433_cmu_data {
 	struct samsung_clk_provider ctx;
 };
 
-static int exynos5433_cmu_suspend(struct device *dev)
+static int __maybe_unused exynos5433_cmu_suspend(struct device *dev)
 {
 	struct exynos5433_cmu_data *data = dev_get_drvdata(dev);
 	int i;
@@ -5473,7 +5473,7 @@  static int exynos5433_cmu_suspend(struct device *dev)
 	return 0;
 }
 
-static int exynos5433_cmu_resume(struct device *dev)
+static int __maybe_unused exynos5433_cmu_resume(struct device *dev)
 {
 	struct exynos5433_cmu_data *data = dev_get_drvdata(dev);
 	int i;