[1/2] ASoC: dapm: add initialization for w_param_text pointer

Message ID 20171010092052.2551973-1-arnd@arndb.de
State New
Headers show
  • [1/2] ASoC: dapm: add initialization for w_param_text pointer
Related show

Commit Message

Arnd Bergmann Oct. 10, 2017, 9:20 a.m.
We now allocate the array conditionally, but we always pass
the pointer to the new snd_soc_dapm_free_kcontrol() function,
which introduces a warning for the case that it is not

sound/soc/soc-dapm.c: In function 'snd_soc_dapm_new_pcm':
sound/soc/soc-dapm.c:3940:2: error: 'w_param_text' may be used uninitialized in this function [-Werror=maybe-uninitialized]

As snd_soc_dapm_free_kcontrol() is global, it doesn't get inlined
and gcc fails to notice that we don't actually access the array
in that case, so the code is actually safe. Adding an initialization
for the array pointer shuts up the warning.

Fixes: 19ad683abc85 ("ASoC: dapm: Avoid creating kcontrol for params")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

 sound/soc/soc-dapm.c | 2 ++
 1 file changed, 2 insertions(+)


Alsa-devel mailing list


diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index ceec185c871f..19babdae1a06 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3905,6 +3905,8 @@  int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
 			ret = -ENOMEM;
 			goto param_fail;
+	} else {
+		w_param_text = NULL;
 	dev_dbg(card->dev, "ASoC: adding %s widget\n", link_name);