From patchwork Wed Oct 11 10:00:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 115532 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp559885qgn; Wed, 11 Oct 2017 03:01:06 -0700 (PDT) X-Received: by 10.98.149.88 with SMTP id p85mr14513654pfd.12.1507716066207; Wed, 11 Oct 2017 03:01:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507716066; cv=none; d=google.com; s=arc-20160816; b=hWQHLsFHoeDbiKsbu3PJCxMCN+g+nMnIwrmCe1Aq/AL508AI5C3I46hPI+S9YCPGwP K8QfQ0ps3Wd/XWS1CBJ6p+ZM/yZ9UB5JC6m6qaz1YWHQbjx4QnIGmJ+LBlda9f2x1OOg oyioCZ7ii3iggGhZA2TvcSRZ7aNTCpJ+mXGqHR5BhRpXllpEdmYFdO9iOspoMhAiXMMh HwY+YyZuUN5icq3jokZ8zXVmfZu7m369hLypve18SkMMDTMGfZzAFqTTExZItDvy9QIa PfXQeRe+YLEZ1qJg8qcTkxqjNwR256eevF/qHaBRp/DVXE5RloKoRODDUj6ojK8flWFq arfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=Zt+se+RhMBZ8jIdaEtZrMseWSsyT903EnWT8RZF4yO8=; b=ab7qNudSnfsZApih2DQt/5ew7e27N6y++4uLf2pisFrL3AVSn3ep7m9zf6SvIbJS+K MhIWTnWsesg6iE+MW+HscQjcuQACGUmaz6LzaTkFFoEQIuoo7pvke90qmUGUAhEtcE+9 kIDAb5GYXGReCiWqwOqwj21Oojwdb7e8VgkBlSnja32fBxlS9zHb275KsyZjYubxXT73 h1lkFWhi27PZYL++f4cN5c0a9DXOD3QBVF5AJKwDx2RE2nlNtleTEWX1zA+SdWuQ7xu1 JBoqgk5hjjib2wiSovhhb90HP4hcv1dFfD+t85h7ClpABa3th7VuIv7g8hC4cKhs87pU mO2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=RnJ92qws; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m61si7503741plb.464.2017.10.11.03.01.06; Wed, 11 Oct 2017 03:01:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=RnJ92qws; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386AbdJKKBF (ORCPT + 5 others); Wed, 11 Oct 2017 06:01:05 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:47358 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdJKKBE (ORCPT ); Wed, 11 Oct 2017 06:01:04 -0400 Received: by mail-lf0-f48.google.com with SMTP id k40so1448408lfi.4 for ; Wed, 11 Oct 2017 03:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=d4FWcR2u6fU0Zi3O83CpUdHgbxmS2f7WeM0K9NNFflg=; b=RnJ92qwsIh3PsUxiLabE3oFf64+i5MIokYrYgpTD7aWoHUwfXdM7+xHXG8CecYk6DE zswYcfOKetlefEnSrwTiQh76qB3rc4Z2Gp4n9unjym0c6i3+xx1YgPirk8p6MkbuTBoP PtDamXZFhCkrVVECtiepJz1PRSIqu+67XpiOY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=d4FWcR2u6fU0Zi3O83CpUdHgbxmS2f7WeM0K9NNFflg=; b=NZr5SsjNNvwt853LiVRC0+GVCBRv9899HL9ZwNi2DTR9YHsF4rqodrnR7BekDwT9Y3 /GmI/TpT4SH5Obn853LLJxeOsSR77JZ1x2k02oghZqc4VirN5PgJu7V8nMckDV6Wx6J5 vHX9LXI1yZyUNWdKESBt/ngcRGdbD4v/WF0qA6w9tfHPXvsWCNq/HUiwM3EL0ltjVY/f kfbQnr1GIZn5/6otWdEotJrlslXrajKKZudKhzgKfFbO+PcF12AImgB2/Bxys8gsbbPG evty4ehL0iBTqvr0blhUK+Haaxl8pScFCOrQ4vmUBEBWGmPPvxPu3NV0UmWPCBfYs5b/ ldpw== X-Gm-Message-State: AMCzsaVsiC0QD6Or1UPAu8+3x6Ee4i1cfwhFBvy7u+FOkINVTwVFrKoz mlDgjp8JJHFdpPJwEWvI2RxG4wP+uIs= X-Google-Smtp-Source: AOwi7QDD2m1frdqrk1cSU3h6dUlZAck2zGUzsai1GOaz7GxcwWK1Xp2ipIqynqmM8GX2RW7bofHKGA== X-Received: by 10.46.91.138 with SMTP id m10mr3777172lje.95.1507716063082; Wed, 11 Oct 2017 03:01:03 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id q28sm1716677lfb.15.2017.10.11.03.01.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Oct 2017 03:01:02 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Steven Miao , Sonic Zhang Subject: [PATCH] pinctrl: adi2: Fix build problem Date: Wed, 11 Oct 2017 12:00:57 +0200 Message-Id: <20171011100057.9051-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.13.5 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The build robot is complaining on Blackfin: drivers/pinctrl/pinctrl-adi2.c: In function 'port_setup': >> drivers/pinctrl/pinctrl-adi2.c:221:21: error: dereferencing pointer to incomplete type 'struct gpio_port_t' writew(readw(®s->port_fer) & ~BIT(offset), ^~ drivers/pinctrl/pinctrl-adi2.c: In function 'adi_gpio_ack_irq': >> drivers/pinctrl/pinctrl-adi2.c:266:18: error: dereferencing pointer to incomplete type 'struct bfin_pint_regs' if (readl(®s->invert_set) & pintbit) ^~ It seems the driver need to include and to compile. Cc: Steven Miao Cc: Sonic Zhang Signed-off-by: Linus Walleij --- Sonic: tell me if you know what is going on. This driver *IS* in use, right? --- drivers/pinctrl/pinctrl-adi2.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.13.5 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index 56aa181084ac..eb9ac0853008 100644 --- a/drivers/pinctrl/pinctrl-adi2.c +++ b/drivers/pinctrl/pinctrl-adi2.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include #include "pinctrl-adi2.h" #include "core.h"