[v6,23/50] hack dump tb->flags and tb->cflags

Message ID 20171016172609.23422-24-richard.henderson@linaro.org
State New
Headers show
Series
  • tcg tb_lock removal
Related show

Commit Message

Richard Henderson Oct. 16, 2017, 5:25 p.m.
---
 accel/tcg/cpu-exec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.13.6

Comments

Emilio G. Cota Oct. 18, 2017, 4:15 a.m. | #1
On Mon, Oct 16, 2017 at 10:25:42 -0700, Richard Henderson wrote:
> ---

>  accel/tcg/cpu-exec.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c

> index 39ec9508d1..99f1d519c5 100644

> --- a/accel/tcg/cpu-exec.c

> +++ b/accel/tcg/cpu-exec.c

> @@ -146,9 +146,9 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb)

>      uint8_t *tb_ptr = itb->tc.ptr;

>  

>      qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc,

> -                           "Trace %p [%d: " TARGET_FMT_lx "] %s\n",

> +                           "Trace %p [%d: " TARGET_FMT_lx ", %x, %x] %s\n",

>                             itb->tc.ptr, cpu->cpu_index, itb->pc,

> -                           lookup_symbol(itb->pc));

> +                           itb->flags, itb->cflags, lookup_symbol(itb->pc));


Given the title, did you indent to submit this patch in the series,
or it was just a private patch for debugging?

		E.
Richard Henderson Oct. 18, 2017, 4:49 a.m. | #2
On 10/17/2017 09:15 PM, Emilio G. Cota wrote:
> On Mon, Oct 16, 2017 at 10:25:42 -0700, Richard Henderson wrote:

>> ---

>>  accel/tcg/cpu-exec.c | 4 ++--

>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>

>> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c

>> index 39ec9508d1..99f1d519c5 100644

>> --- a/accel/tcg/cpu-exec.c

>> +++ b/accel/tcg/cpu-exec.c

>> @@ -146,9 +146,9 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb)

>>      uint8_t *tb_ptr = itb->tc.ptr;

>>  

>>      qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc,

>> -                           "Trace %p [%d: " TARGET_FMT_lx "] %s\n",

>> +                           "Trace %p [%d: " TARGET_FMT_lx ", %x, %x] %s\n",

>>                             itb->tc.ptr, cpu->cpu_index, itb->pc,

>> -                           lookup_symbol(itb->pc));

>> +                           itb->flags, itb->cflags, lookup_symbol(itb->pc));

> 

> Given the title, did you indent to submit this patch in the series,

> or it was just a private patch for debugging?


It was supposed to be private.  Oops.


r~

Patch

diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 39ec9508d1..99f1d519c5 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -146,9 +146,9 @@  static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb)
     uint8_t *tb_ptr = itb->tc.ptr;
 
     qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc,
-                           "Trace %p [%d: " TARGET_FMT_lx "] %s\n",
+                           "Trace %p [%d: " TARGET_FMT_lx ", %x, %x] %s\n",
                            itb->tc.ptr, cpu->cpu_index, itb->pc,
-                           lookup_symbol(itb->pc));
+                           itb->flags, itb->cflags, lookup_symbol(itb->pc));
 
 #if defined(DEBUG_DISAS)
     if (qemu_loglevel_mask(CPU_LOG_TB_CPU)