From patchwork Wed Oct 18 07:00:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 116215 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp5743892qgn; Wed, 18 Oct 2017 00:03:18 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBYomCx1vQZ9tBqRKOsyRLvunZ+Y/9OosCGHF2cajxMYZ+PYBIM0/Dn1CwClmxpW+l2ESsk X-Received: by 10.99.98.197 with SMTP id w188mr12951862pgb.41.1508310198250; Wed, 18 Oct 2017 00:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508310198; cv=none; d=google.com; s=arc-20160816; b=a0uZ+oOgKIMJRZepId6JmvxoBf1LM/KxZqzC4VHWnCQ7UWqyce1Jx3dXfezUkGNCa9 Ha8jcyjQeZxZtL63hSUwLUh/bcJx65thzWShAOMguyat5VGW/eVo+vRzpF4utp64AGmZ J0Bwvml9YIlk0YIm/n+Mtkw5lxL+odEXevcbSWlz/lqcdt96iOE2tMrG2f9wxHlGhh84 ZKWGnPtwpjMhNB6p//ofmFk6A4MYrNgPdK9sGgmpMCngEFrU/qD7sMtWXMYzHcUN2oI8 lv46oa92Bnbu0NM55IExE2Lpwf3gEsB9UvhM8uaYMChvyfX1zfTlpuuJSQN3mXh5vNH8 Ft7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=LFdLIGhk89Nk3xz3nzAcr4UBIYZLnnWiktWdiwd9iDw=; b=YbRXli2Pqs6kfPNJ49DtwUHgSZ3UQ/9Kkcx7wJWESfetzny4ZNLqsvkEDZk5Be5yt7 OoX2jlIK/DPxsqcp05LQZbwnERLgfC0yJC1nITsp/hF/0TXuVHyS8JcIpgOWCGa5ANAk EgwnLMTBPYjyjU5mVVwdzHYj9TVNaDRvU/ECSwF5qI+0rizvpM3q5/xAla7iGdMs6VMc UYQbpk0nz56oP2A5Uo8Oj5x/cRNp4iIgC47qTs4tTXt5KaWm6XKG2nREzifxyfAb1LGS hV6hKJlnD2RJTUtyuMhCqBrmQK93plbfM2788sJVywofG139X4dKRpRrvplFCA0eeFSt YSPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k8si6534110pgn.524.2017.10.18.00.03.17; Wed, 18 Oct 2017 00:03:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966554AbdJRHDP (ORCPT + 27 others); Wed, 18 Oct 2017 03:03:15 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33446 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966495AbdJRHDL (ORCPT ); Wed, 18 Oct 2017 03:03:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA513F; Wed, 18 Oct 2017 00:03:10 -0700 (PDT) Received: from localhost.localdomain (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96C273F590; Wed, 18 Oct 2017 00:03:02 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Steve French , "Theodore Y. Ts'o" , Jaegeuk Kim , Steffen Klassert , Alexey Kuznetsov , Hideaki YOSHIFUJI , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" Cc: Ofir Drang , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org, netdev@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org Subject: [PATCH v10 05/20] crypto: marvell/cesa: remove redundant backlog checks on EBUSY Date: Wed, 18 Oct 2017 08:00:37 +0100 Message-Id: <1508310057-25369-6-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1508310057-25369-1-git-send-email-gilad@benyossef.com> References: <1508310057-25369-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef Acked-by: Boris Brezillon --- drivers/crypto/marvell/cesa.c | 3 +-- drivers/crypto/marvell/cesa.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c index b657e7c..ff73aa5 100644 --- a/drivers/crypto/marvell/cesa.c +++ b/drivers/crypto/marvell/cesa.c @@ -181,8 +181,7 @@ int mv_cesa_queue_req(struct crypto_async_request *req, spin_lock_bh(&engine->lock); ret = crypto_enqueue_request(&engine->queue, req); if ((mv_cesa_req_get_type(creq) == CESA_DMA_REQ) && - (ret == -EINPROGRESS || - (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG))) + (ret == -EINPROGRESS || ret == -EBUSY)) mv_cesa_tdma_chain(engine, creq); spin_unlock_bh(&engine->lock); diff --git a/drivers/crypto/marvell/cesa.h b/drivers/crypto/marvell/cesa.h index b7872f6..63c8457 100644 --- a/drivers/crypto/marvell/cesa.h +++ b/drivers/crypto/marvell/cesa.h @@ -763,7 +763,7 @@ static inline int mv_cesa_req_needs_cleanup(struct crypto_async_request *req, * the backlog and will be processed later. There's no need to * clean it up. */ - if (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG) + if (ret == -EBUSY) return false; /* Request wasn't queued, we need to clean it up */