From patchwork Wed Oct 18 07:25:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 116232 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp5759736qgn; Wed, 18 Oct 2017 00:25:59 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDUzr+Ng931E11Sjy6zno+zLDjpO2i7mDaOwH8pAZaOUd7p/bCEn6fCM83EtmK2xpn7SfSs X-Received: by 10.101.77.198 with SMTP id q6mr12767417pgt.108.1508311558966; Wed, 18 Oct 2017 00:25:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508311558; cv=none; d=google.com; s=arc-20160816; b=SxT+bFZjMwzM/M+H48pHYfWAnR8joriCZm5KYtEMfgWWqGqokr2bACoDX7vNfl35Fo KoCWNyB17IIpQX+ZR0uOysCts7wyk2rEH7MqUFjWzz2cy5GJydNSC6H9Mjo76mzNV3us Xc/2dtBMTo4Jq2l60xSwt4a6YZ1w3Aqv3D+Omz/CpWGcd1xRhXpQPYpRec1wjwztECC5 zgkGPtCKbaocwFoPcFJlqrnBAq2wWLq8JqPjKIa+Qj9jMS32xaZMxX9Bq9xJJmU8EsxN jRNd8fOCw4JDi7mmeN5Q9b/HC4DaJUARIBQbug72zhlRsMnbBCnyYuoI1Daknz0R24N3 HbUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:message-id:date :subject:cc:to:from:arc-authentication-results; bh=RL9xA+lmMjjzWZiFFtInJAOQr9hofdLnGt80fcMGorU=; b=nKBf6eVNKMWfLj6yA8sz3Axv2i9biiwtj6pKKD0Q/G7rg8zXHupX/g5n9AyXKjjg55 LpVTXoqe79KimhB+9hRvbAFA+uhEzJ+ETUovva9lzbYTp8B5cwkdtbAIMIx0/j8bVtrC UxiGtqwA0bBRQuVXruH0D9ePAvwLHyeW1ZUH+gfqV7sVi7sGairq4ASsnbcnFnnIeMWC 1bgwIdmrH7WHOZD76LTvl/SnB1Hh0w4x60aa25hxrDtMef2eoXCEPBvxxCUUqtiCw1X7 y34AARnv73iQDd/y1QoRhpE5XFT09k8uuo8jXxs1gn4UdkLhR1iBeM+IO/3f6aNf0BPx +IrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si4757220pls.819.2017.10.18.00.25.58; Wed, 18 Oct 2017 00:25:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935584AbdJRHZ6 (ORCPT + 4 others); Wed, 18 Oct 2017 03:25:58 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51248 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935588AbdJRHZ4 (ORCPT ); Wed, 18 Oct 2017 03:25:56 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20171018072554euoutp010ae4f3e80455951fcacafd83b385fd8e~umV4LbeRl0222902229euoutp01Z; Wed, 18 Oct 2017 07:25:54 +0000 (GMT) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171018072553eucas1p2c409850b8c38577306767aa2c9200210~umV3bfenN1440414404eucas1p2I; Wed, 18 Oct 2017 07:25:53 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges5.samsung.com (EUCPMTA) with SMTP id F6.9A.12743.10207E95; Wed, 18 Oct 2017 08:25:53 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171018072552eucas1p2ec41e98c5bc004f6ada02987fd55222a~umV2knBEL0790907909eucas1p2x; Wed, 18 Oct 2017 07:25:52 +0000 (GMT) X-AuditID: cbfec7f5-f79d06d0000031c7-9e-59e7020183b6 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AD.E9.18832.00207E95; Wed, 18 Oct 2017 08:25:52 +0100 (BST) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OY000B2XCMX0UA0@eusync3.samsung.com>; Wed, 18 Oct 2017 08:25:52 +0100 (BST) From: Marek Szyprowski To: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Mark Brown , Sylwester Nawrocki , Sangbeom Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH] ASoC: samsung: i2s: disable secondary DAI until it gets fixed Date: Wed, 18 Oct 2017 09:25:34 +0200 Message-id: <20171018072534.21204-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.14.2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsWy7djPc7qMTM8jDZqmiVpcuXiIyWLjjPWs FlMfPmGzOH9+A7vFjPP7mCzWHrnLbnH4TTurxcUVX5gcODw2fG5i89i0qpPNo2/LKkaPz5vk AliiuGxSUnMyy1KL9O0SuDJu/d7CUvBGuuL76Q7WBsY3El2MnBwSAiYSKz/cY4awxSQu3FvP 1sXIxSEksJRRYvrOhSwQzmdGiWXP21hgOta9uQeVWMYocX35HCingUni5+77YLPYBAwlut52 sYHYIgJOEjPnvAebyyzQwiRx/d1EVpCEsECAxJ+LfYwgNouAqsTDlZPYQWxeAVuJ5rfL2SHW yUu8X3CfEaRZQuArq0TbgS2MEAkXibsnb7NB2MISr45vgWqQkejsOMgEYfczSjS1akPYMxgl zr3lhbCtJQ4fvwh2BLMAn8SkbdOBruYAivNKdLQJQZR4SNyePA9qpKNEz4NNYOVCArESn3Ye YJ3AKLWAkWEVo0hqaXFuemqxqV5xYm5xaV66XnJ+7iZGYEye/nf86w7GpcesDjEKcDAq8fAG qDyLFGJNLCuuzD3EKMHBrCTCy/wRKMSbklhZlVqUH19UmpNafIhRmoNFSZzXNqotUkggPbEk NTs1tSC1CCbLxMEp1cBY/GAaw8s62+UvNjsHKlyu+ZvEu/nYkajtptM3criuz55w6wzrLVGd v0sudz+VCjzz67/mZ9WYW5F2PH3uVzm+GOar+we8POX05xf/sUfnd1q8Ec/TU+s/acG/4qJp irdK39el4sGlKx0EKsx5eQr3ajEF/F5VKqSRH+bZl8HlO98xxfZio6USS3FGoqEWc1FxIgAr pL5cxQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNJMWRmVeSWpSXmKPExsVy+t/xq7oMTM8jDXZf0LC4cvEQk8XGGetZ LaY+fMJmcf78BnaLGef3MVmsPXKX3eLwm3ZWi4srvjA5cHhs+NzE5rFpVSebR9+WVYwenzfJ BbBEcdmkpOZklqUW6dslcGXc+r2FpeCNdMX30x2sDYxvJLoYOTkkBEwk1r25xwJhi0lcuLee rYuRi0NIYAmjxPufX5ggnCYmiYm/d7CCVLEJGEp0ve1iA7FFBJwkZs55D2YzC7QwSfz5yA9i Cwv4SRxt7mUGsVkEVCUerpzEDmLzCthKNL9dzg6xTV7i/YL7jBMYuRcwMqxiFEktLc5Nzy02 1CtOzC0uzUvXS87P3cQIDJJtx35u3sF4aWPwIUYBDkYlHt4AlWeRQqyJZcWVuYcYJTiYlUR4 mT8ChXhTEiurUovy44tKc1KLDzFKc7AoifP27lkdKSSQnliSmp2aWpBaBJNl4uCUamCseqHc ss826bdCmvnXp36P3+xaqrHjY6rtBubG7EBJplsMb14Z23Ap/Mg9t6/m/Iebzw7odW+7Xbd8 o2R7+q5Htze/Xfdpnu7SJJknnAtO+T5jjTK9frN+ferX0z47T96wYL+eeN/b37jid3iEVPDz Xp5b1ctspI7tK5+/b6dR803nJTyFek8jlViKMxINtZiLihMBda8cDA4CAAA= X-CMS-MailID: 20171018072552eucas1p2ec41e98c5bc004f6ada02987fd55222a X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?utf-8?q?Marek_Szyprowski=1BSRPOL-Kernel_=28TP=29=1B?= =?utf-8?b?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?utf-8?q?Marek_Szyprowski=1BSRPOL-Kernel_=28TP=29=1BSam?= =?utf-8?q?sung_Electronics=1BSenior_Software_Engineer?= X-Sender-Code: =?utf-8?q?C10=1BEHQ=1BC10CD02CD027392?= CMS-TYPE: 201P X-CMS-RootMailID: 20171018072552eucas1p2ec41e98c5bc004f6ada02987fd55222a X-RootMTR: 20171018072552eucas1p2ec41e98c5bc004f6ada02987fd55222a References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Secondary DAI in Exynos I2S driver is not used by any of the currently supported boards and it causes problems due to some limitations in the ASoC code. Disable it until it gets proper support both by board-specific and ASoC core code. Also disable IDMA support, which relies on secondary DAI presence. This patch fixes following kernel warning: samsung-i2s 3830000.i2s: ASoC: Failed to create component debugfs directory samsung-i2s 3830000.i2s: ASoC: Failed to create component debugfs directory ------------[ cut here ]------------ WARNING: CPU: 3 PID: 82 at fs/proc/generic.c:330 proc_register+0xec/0x10c proc_dir_entry 'sub0/prealloc' already registered Modules linked in: CPU: 3 PID: 82 Comm: kworker/3:1 Not tainted 4.14.0-rc5-next-20171017 #3089 Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) Workqueue: events deferred_probe_work_func [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x90/0xc8) [] (dump_stack) from [] (__warn+0xd4/0x100) [] (__warn) from [] (warn_slowpath_fmt+0x38/0x48) [] (warn_slowpath_fmt) from [] (proc_register+0xec/0x10c) [] (proc_register) from [] (proc_create_data+0x84/0xc8) [] (proc_create_data) from [] (snd_info_register+0x64/0xcc) [] (snd_info_register) from [] (snd_pcm_lib_preallocate_pages1+0x78/0x1a0) [] (snd_pcm_lib_preallocate_pages1) from [] (dmaengine_pcm_new+0xa0/0x1ec) [] (dmaengine_pcm_new) from [] (snd_soc_platform_drv_pcm_new+0x1c/0x28) [] (snd_soc_platform_drv_pcm_new) from [] (soc_new_pcm+0x2f4/0x4f4) [] (soc_new_pcm) from [] (snd_soc_register_card+0xc4c/0xdc4) [] (snd_soc_register_card) from [] (devm_snd_soc_register_card+0x34/0x70) [] (devm_snd_soc_register_card) from [] (asoc_simple_card_probe+0x230/0x47c) [] (asoc_simple_card_probe) from [] (platform_drv_probe+0x50/0xb0) [] (platform_drv_probe) from [] (driver_probe_device+0x2a0/0x46c) [] (driver_probe_device) from [] (bus_for_each_drv+0x44/0x8c) [] (bus_for_each_drv) from [] (__device_attach+0xa0/0x134) [] (__device_attach) from [] (bus_probe_device+0x88/0x90) [] (bus_probe_device) from [] (deferred_probe_work_func+0x3c/0x168) [] (deferred_probe_work_func) from [] (process_one_work+0x188/0x41c) [] (process_one_work) from [] (process_scheduled_works+0x28/0x38) [] (process_scheduled_works) from [] (worker_thread+0x210/0x4dc) [] (worker_thread) from [] (kthread+0x128/0x164) [] (kthread) from [] (ret_from_fork+0x14/0x2c) ---[ end trace bad8db6ee771d094 ]-- Signed-off-by: Marek Szyprowski --- sound/soc/samsung/i2s.c | 1 + 1 file changed, 1 insertion(+) -- 2.14.2 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 8d5e1861abb1..233f1c9a4b6c 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -1292,6 +1292,7 @@ static int samsung_i2s_probe(struct platform_device *pdev) } } } + quirks &= ~(QUIRK_SEC_DAI | QUIRK_SUPPORTS_IDMA); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); pri_dai->addr = devm_ioremap_resource(&pdev->dev, res);