thermal/drivers/hisi: disable multi alarm support for hi3660 SoC

Message ID 1508318150-108444-1-git-send-email-kevin.wangtao@hisilicon.com
State New
Headers show
Series
  • thermal/drivers/hisi: disable multi alarm support for hi3660 SoC
Related show

Commit Message

Wangtao (Kevin, Kirin) Oct. 18, 2017, 9:15 a.m.
From: Kevin Wangtao <kevin.wangtao@linaro.org>


multi alarm interrupt forced a re-trigger of power_allocator_throttle
which changes the PID's actual sampling rate, this isn't optimal for
IPA, it is best to disable multi alarm support now and sort out this
issue later.

Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org>

---
 drivers/thermal/hisi_thermal.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.8.1

Comments

Wangtao (Kevin, Kirin) Oct. 19, 2017, 1:31 a.m. | #1
在 2017/10/18 23:54, Daniel Lezcano 写道:
> On 18/10/2017 11:15, Tao Wang wrote:

>> From: Kevin Wangtao <kevin.wangtao@linaro.org>

>>

>> multi alarm interrupt forced a re-trigger of power_allocator_throttle

>> which changes the PID's actual sampling rate, this isn't optimal for

>> IPA, it is best to disable multi alarm support now and sort out this

>> issue later.

>>

>> Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org>

> 

> Did you test the series with this change?

Yes
> 

>> ---

>>   drivers/thermal/hisi_thermal.c | 1 -

>>   1 file changed, 1 deletion(-)

>>

>> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c

>> index 133238a..3b74c12 100644

>> --- a/drivers/thermal/hisi_thermal.c

>> +++ b/drivers/thermal/hisi_thermal.c

>> @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data)

>>   

>>   	/* set interrupt threshold */

>>   	value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]);

>> -	value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10;

>>   	hi3660_thermal_alarm_set(data->regs, sensor->id, value);

>>   

>>   	/* enable interrupt */

>>

> 

>
Eduardo Valentin Dec. 5, 2017, 2:02 a.m. | #2
Hello,

On Thu, Oct 19, 2017 at 09:31:24AM +0800, Wangtao (Kevin, Kirin) wrote:
> 

> 

> 在 2017/10/18 23:54, Daniel Lezcano 写道:

> >On 18/10/2017 11:15, Tao Wang wrote:

> >>From: Kevin Wangtao <kevin.wangtao@linaro.org>

> >>

> >>multi alarm interrupt forced a re-trigger of power_allocator_throttle

> >>which changes the PID's actual sampling rate, this isn't optimal for

> >>IPA, it is best to disable multi alarm support now and sort out this

> >>issue later.

> >>

> >>Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org>

> >

> >Did you test the series with this change?

> Yes


Is this patch still valid with the latest linus master?
Daniel Lezcano Dec. 5, 2017, 6:57 a.m. | #3
On 05/12/2017 03:02, Eduardo Valentin wrote:
> Hello,

> 

> On Thu, Oct 19, 2017 at 09:31:24AM +0800, Wangtao (Kevin, Kirin) wrote:

>>

>>

>> 在 2017/10/18 23:54, Daniel Lezcano 写道:

>>> On 18/10/2017 11:15, Tao Wang wrote:

>>>> From: Kevin Wangtao <kevin.wangtao@linaro.org>

>>>>

>>>> multi alarm interrupt forced a re-trigger of power_allocator_throttle

>>>> which changes the PID's actual sampling rate, this isn't optimal for

>>>> IPA, it is best to disable multi alarm support now and sort out this

>>>> issue later.

>>>>

>>>> Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org>

>>>

>>> Did you test the series with this change?

>> Yes

> 

> Is this patch still valid with the latest linus master?


No, it was folded in the next iteration.

All patches for hisilicon are up-to-date.

Thanks.

 -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Patch

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index 133238a..3b74c12 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -360,7 +360,6 @@  static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data)
 
 	/* set interrupt threshold */
 	value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]);
-	value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10;
 	hi3660_thermal_alarm_set(data->regs, sensor->id, value);
 
 	/* enable interrupt */