From patchwork Mon Oct 23 21:07:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 116877 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5084235qgn; Mon, 23 Oct 2017 14:10:11 -0700 (PDT) X-Google-Smtp-Source: ABhQp+S6aHn7AoBbd96wlc2Cfudg1brVgEcPay/H36OcSVUnbd+mVqFC+UQRg/E2sEWN5RLW7Cq7 X-Received: by 10.98.178.86 with SMTP id x83mr14397535pfe.332.1508793011842; Mon, 23 Oct 2017 14:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508793011; cv=none; d=google.com; s=arc-20160816; b=jbib2XsPNUAN6ezVJZKWSw3Vvyy1XUla/hzKJL/LdEnxVJctCus23skQNzejkLAKzM txDulF0x0Pk+z9hMds42ev0XkCSIjI8VHI5w9l9FOE8wer1d6ukTwGlJ81kt33YojjPv 3lMxot03atahjA0eDR2dQHiBTatqxcWGlCCb8GVRay6OPGYsB/qrDJ6s4NCouSqOLlr4 BhtnI3Y99nlMx07YFCBrhaUNpxpLI09x81Gln8cN0CfxOULYzTBFcdIBgYnnh1AFI3a0 S0joGZ2MHW5/aSbofVoBwn7OIlsgSimR8bSJgtiCnSyMtPK0QnVn3ChkQO1V0SPc5wus VgLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=TH8JTKSHqCdRS2KgzfgdDXMugS1lJSreF5t8Dn2wG98=; b=rwfe70XNNOm+xOXTHxLxMo4Fe0JtGM47/xFMH4tfPvoUlKUF26bU5ECy4BK4JZTcJY CBZjKTKhT/228anrYN2xdoG041XBKZJrDmZDlNC49ouV8ETaSBLe2dVQNeDAymqzDRH1 VptLeBbJKR6JzHdPa+kQG/JlNJOZsQXKTv3lYVIFjLBF/kViFfHAPOYuLo6ZZ9EqiNeU CwellrC6oQougTJ46H08wP3EYybG7ALfIiUi/bmGd6Hj4oiLcfVDWIardBVN6y2IY67g RooKoO18ItwT43Y4empdxPyuNB+sC1ZbsLmCPAGzEr/SIl2L3sq4fqBj2YOZASWcmBmI EghA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p128si5344702pga.639.2017.10.23.14.10.11; Mon, 23 Oct 2017 14:10:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbdJWVKK (ORCPT + 27 others); Mon, 23 Oct 2017 17:10:10 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54092 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdJWVHm (ORCPT ); Mon, 23 Oct 2017 17:07:42 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9NL7eGd006470 for ; Mon, 23 Oct 2017 17:07:42 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dsng0q0q9-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 23 Oct 2017 17:07:42 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Oct 2017 17:07:40 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 23 Oct 2017 17:07:35 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v9NL7Ywr1835468; Mon, 23 Oct 2017 21:07:34 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E16A3B2052; Mon, 23 Oct 2017 17:04:48 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.80.218.156]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP id C8E2AB2054; Mon, 23 Oct 2017 17:04:48 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id AC01C16C3449; Mon, 23 Oct 2017 14:07:33 -0700 (PDT) From: "Paul E. McKenney" To: mingo@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, will.deacon@arm.com, mark.rutland@arm.com, snitzer@redhat.com, thor.thayer@linux.intel.com, viro@zeniv.linux.org.uk, davem@davemloft.net, shuah@kernel.org, mpe@ellerman.id.au, tj@kernel.org, torvalds@linux-foundation.org, Petr Vandrovec Subject: [PATCH 05/19] fs: ncpfs: Kill off ACCESS_ONCE() Date: Mon, 23 Oct 2017 14:07:15 -0700 X-Mailer: git-send-email 2.5.2 In-Reply-To: <20171023210408.GA2930@linux.vnet.ibm.com> References: <20171023210408.GA2930@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17102321-0052-0000-0000-00000275FAAA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007941; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00935454; UDB=6.00471299; IPR=6.00715720; BA=6.00005656; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017676; XFM=3.00000015; UTC=2017-10-23 21:07:38 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102321-0053-0000-0000-000052690721 Message-Id: <1508792849-3115-5-git-send-email-paulmck@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-10-23_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710230296 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Rutland The NCPFS code has some stale comments regarding ACCESS_ONCE() uses which were removed a long time ago. Let's remove the stale comments. Signed-off-by: Mark Rutland Cc: Alexander Viro Cc: Petr Vandrovec --- fs/ncpfs/dir.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.5.2 diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 088f52484d6e..72cfaa253a8f 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c @@ -119,10 +119,6 @@ static inline int ncp_case_sensitive(const struct inode *i) /* * Note: leave the hash unchanged if the directory * is case-sensitive. - * - * Accessing the parent inode can be racy under RCU pathwalking. - * Use ACCESS_ONCE() to make sure we use _one_ particular inode, - * the callers will handle races. */ static int ncp_hash_dentry(const struct dentry *dentry, struct qstr *this) @@ -147,11 +143,6 @@ ncp_hash_dentry(const struct dentry *dentry, struct qstr *this) return 0; } -/* - * Accessing the parent inode can be racy under RCU pathwalking. - * Use ACCESS_ONCE() to make sure we use _one_ particular inode, - * the callers will handle races. - */ static int ncp_compare_dentry(const struct dentry *dentry, unsigned int len, const char *str, const struct qstr *name)