drm_hwcomposer: remove unnecessary external includes

Message ID 20171025000643.9398-1-robh@kernel.org
State New
Headers show
Series
  • drm_hwcomposer: remove unnecessary external includes
Related show

Commit Message

Rob Herring Oct. 25, 2017, 12:06 a.m.
Linking to libraries will add necessary include paths, so we don't need to
list them explicitly.

Still need libsync for sw_sync.h until this dependency is removed.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Android.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Chih-Wei Huang Oct. 25, 2017, 2:21 a.m. | #1
2017-10-25 8:06 GMT+08:00 Rob Herring <robh@kernel.org>:
> Linking to libraries will add necessary include paths, so we don't need to
> list them explicitly.
>
> Still need libsync for sw_sync.h until this dependency is removed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Android.mk | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Android.mk b/Android.mk
> index 109e352f2a0e..8b11e375adde 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
>
>  LOCAL_C_INCLUDES := \
>         external/drm_gralloc \
> -       external/libdrm \
> -       external/libdrm/include/drm \
> -       system/core/include/utils \
> -       system/core/libsync \
> -       system/core/libsync/include \
> +       system/core/libsync
>
>  LOCAL_SRC_FILES := \
>         autolock.cpp \
> --

Looks good to me
Reviewed-and-tested-by: Chih-Wei Huang <cwhuang@linux.org.tw>
Sean Paul Oct. 25, 2017, 7:28 a.m. | #2
On Wed, Oct 25, 2017 at 10:21:14AM +0800, Chih-Wei Huang wrote:
> 2017-10-25 8:06 GMT+08:00 Rob Herring <robh@kernel.org>:
> > Linking to libraries will add necessary include paths, so we don't need to
> > list them explicitly.
> >
> > Still need libsync for sw_sync.h until this dependency is removed.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  Android.mk | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/Android.mk b/Android.mk
> > index 109e352f2a0e..8b11e375adde 100644
> > --- a/Android.mk
> > +++ b/Android.mk
> > @@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
> >
> >  LOCAL_C_INCLUDES := \
> >         external/drm_gralloc \
> > -       external/libdrm \
> > -       external/libdrm/include/drm \
> > -       system/core/include/utils \
> > -       system/core/libsync \
> > -       system/core/libsync/include \
> > +       system/core/libsync
> >
> >  LOCAL_SRC_FILES := \
> >         autolock.cpp \
> > --
> 
> Looks good to me
> Reviewed-and-tested-by: Chih-Wei Huang <cwhuang@linux.org.tw>

Applied, thanks for the patch & review.

Sean

> 
> -- 
> Chih-Wei
> Android-x86 project
> http://www.android-x86.org
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/Android.mk b/Android.mk
index 109e352f2a0e..8b11e375adde 100644
--- a/Android.mk
+++ b/Android.mk
@@ -48,11 +48,7 @@  LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
 
 LOCAL_C_INCLUDES := \
 	external/drm_gralloc \
-	external/libdrm \
-	external/libdrm/include/drm \
-	system/core/include/utils \
-	system/core/libsync \
-	system/core/libsync/include \
+	system/core/libsync
 
 LOCAL_SRC_FILES := \
 	autolock.cpp \