diff mbox

[Resend] extcon: Fix return value in extcon_register_interest()

Message ID 1348570879-24067-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat Sept. 25, 2012, 11:01 a.m. UTC 
Propagate the value returned from extcon_find_cable_index()
instead of -ENODEV. For readability, -EINVAL is returned in place of
the variable.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/extcon/extcon-class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Chanwoo Choi Sept. 25, 2012, 11:19 p.m. UTC | #1 
On 09/25/2012 08:01 PM, Sachin Kamat wrote:

> Propagate the value returned from extcon_find_cable_index()
> instead of -ENODEV. For readability, -EINVAL is returned in place of
> the variable.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---

Applied, thank you.

You can check it after some hours at below git repository for Extcon.
-
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next

Thanks,
Chanwoo Choi
diff mbox

Patch

diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index 946a318..6348b64 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -475,7 +475,7 @@  int extcon_register_interest(struct extcon_specific_cable_nb *obj,
 
 	obj->cable_index = extcon_find_cable_index(obj->edev, cable_name);
 	if (obj->cable_index < 0)
-		return -ENODEV;
+		return -EINVAL;
 
 	obj->user_nb = nb;