[1/2] aarch64: Remove AARCH64_FEATURE_F16 from AARCH64_ARCH_V8_2

Message ID 1509108519-16813-1-git-send-email-siddhesh@gotplt.org
State New
Headers show
Series
  • [1/2] aarch64: Remove AARCH64_FEATURE_F16 from AARCH64_ARCH_V8_2
Related show

Commit Message

Siddhesh Poyarekar Oct. 27, 2017, 12:48 p.m.
From: Siddhesh Poyarekar <siddhesh.poyarekar@linaro.org>


The FP16 feature is optional in ARMv8.2, so it is wrong to add it to
the default AARCH64_ARCH_V8_2 feature flags.  This patch makes the
behaviour consistent with that of gcc, which also does not assume FP16
for ARMv8.2.

	* include/opcode/aarch64.h (AARCH64_ARCH_V8_2): Drop
	AARCH64_FEATURE_F16.

---
 include/opcode/aarch64.h | 1 -
 1 file changed, 1 deletion(-)

-- 
2.7.5

Comments

Nick Clifton Oct. 30, 2017, 1:54 p.m. | #1
Hi Siddhesh,

> 	* include/opcode/aarch64.h (AARCH64_ARCH_V8_2): Drop

> 	AARCH64_FEATURE_F16.


Approved - please apply.

Cheers
  Nick
Siddhesh Poyarekar Nov. 2, 2017, 5:21 p.m. | #2
On Monday 30 October 2017 07:24 PM, Nick Clifton wrote:
> Hi Siddhesh,

> 

>> 	* include/opcode/aarch64.h (AARCH64_ARCH_V8_2): Drop

>> 	AARCH64_FEATURE_F16.

> 

> Approved - please apply.


Thanks, pushed.

Siddhesh

Patch

diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index c5788e2..ea45a41 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -70,7 +70,6 @@  typedef uint32_t aarch64_insn;
 						 | AARCH64_FEATURE_RDMA)
 #define AARCH64_ARCH_V8_2	AARCH64_FEATURE (AARCH64_ARCH_V8_1,	\
 						 AARCH64_FEATURE_V8_2	\
-						 | AARCH64_FEATURE_F16	\
 						 | AARCH64_FEATURE_RAS)
 #define AARCH64_ARCH_V8_3	AARCH64_FEATURE (AARCH64_ARCH_V8_2,	\
 						 AARCH64_FEATURE_V8_3	\