From patchwork Mon Oct 30 13:04:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 117460 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2563158qgn; Mon, 30 Oct 2017 06:05:19 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QtgA6cIMgbgirJYnd65BdJL6xm2oQ0KWMedODh3rQ/UWW3IzHpel5L05kgf/muv5ioAOlY X-Received: by 10.98.234.9 with SMTP id t9mr8719208pfh.92.1509368719033; Mon, 30 Oct 2017 06:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509368719; cv=none; d=google.com; s=arc-20160816; b=CtthdUddH2S/yDd91Tb/q2ohFM5ZPaTXDIgvKuC3i3Mr/+vMgRKkp411LPoXqA/iOt UdE7rChaJ3IZ4m1k7MAZH7ns8LV5WUhje7mnmf28YpHF0RoveDG6aIIKyEqTZFth5L+w X176bUTUsCzREVzu2vITo5NcLTFTa6K1xXU9TfBoUn1EEqlA2MTmxw47DAOuJtYzFB7O kML3vTFqQ2y9YkpZMUQeUN+thbf1K0JWCOarJJgdrlVTdjRbE3LUuHvg4yJvP7uLkgbc Mxd1Xrrz6jWzbC7KPq1GMc6EX9vuzoLnDDykGg/GnVdt8Y08Zuj0Agsp2ix2fuSi4FSR SIVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=zgRzgoxCgQTQoh+7lKSE8xzcm+fgIzQUqdMlg9gwPvQ=; b=a9bqkl86irusJxCLT65NHE+8S0ReflW4/bLDQQpR9HnbUHxW8YRFBfwiG+1w8saxST mh1iaPiSHoIumsmzTYTHBFE1yVR0ls6JVtCdSPh9l3/OV5NvCQcItwQbX1RtWjv82I63 KNZYkn2eD2U6lf1y5bIVOVuaxTyGuIdf8RHp7hum/ijbFF2DxFQ8oCoyiPsx/QACmQnz V1P5kH7xeV3Gi1KYdZ4V9z3r5XBdawT4XrdzsMLP/8MAXs5VLU65aI8p3NNkvfxUIcyq 0Be/R9JbIRV5CGUFLK9ccE+9S3/RT+GUIc4tEtCX36k/bY/KaoUO6w3vNkPiZLG7STlZ GUog== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=tb3vPRAo; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si10891364pfe.573.2017.10.30.06.05.18; Mon, 30 Oct 2017 06:05:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=tb3vPRAo; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751600AbdJ3NFQ (ORCPT + 4 others); Mon, 30 Oct 2017 09:05:16 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:53042 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbdJ3NFO (ORCPT ); Mon, 30 Oct 2017 09:05:14 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v9UD59Tn011274; Mon, 30 Oct 2017 08:05:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1509368709; bh=qfv+oOJKCN8gFsVzPLWDLwUFh/sT1IpZXyOT6PFjUuE=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=tb3vPRAoE7vllu3Sp0TFK5yLtI8zNDAp4Jv/E0EmHhpv6wP7QFH0KESKNMt7eSl7P ej51Pqvc3N6VPPEQVfnDKPv/Ri2suMQccYndznbfTILelDm+kZ23k7W8/mt21NBJLv EkhvwrCVaNWEAcHIH5M3VNKejIQp3Ye9OG3IUPGI= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v9UD58At004432; Mon, 30 Oct 2017 08:05:09 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Mon, 30 Oct 2017 08:05:08 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Mon, 30 Oct 2017 08:05:08 -0500 Received: from gomoku.home (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v9UD54wq005221; Mon, 30 Oct 2017 08:05:06 -0500 From: Tero Kristo To: , , CC: , Subject: [PATCH 01/27] clk: ti: clkctrl: fix error messages to print out node name properly Date: Mon, 30 Oct 2017 15:04:19 +0200 Message-ID: <1509368685-29112-2-git-send-email-t-kristo@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1509368685-29112-1-git-send-email-t-kristo@ti.com> References: <1509368685-29112-1-git-send-email-t-kristo@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Current node name does not convey any information, as it is always "clk". Instead, print out the full node path, which will tell us better where something went wrong. Signed-off-by: Tero Kristo --- drivers/clk/ti/clkctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Sebastian Reichel diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c index 53e71d0..2db7d40 100644 --- a/drivers/clk/ti/clkctrl.c +++ b/drivers/clk/ti/clkctrl.c @@ -351,8 +351,8 @@ static struct clk_hw *_ti_omap4_clkctrl_xlate(struct of_phandle_args *clkspec, if (ti_clk_parse_divider_data((int *)div_data->dividers, div_data->max_div, 0, 0, &div->width, &div->table)) { - pr_err("%s: Data parsing for %s:%04x:%d failed\n", __func__, - node->name, offset, data->bit); + pr_err("%s: Data parsing for %pOF:%04x:%d failed\n", __func__, + node, offset, data->bit); kfree(div); return; } @@ -428,7 +428,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node) } if (!data->addr) { - pr_err("%s not found from clkctrl data.\n", node->name); + pr_err("%pOF not found from clkctrl data.\n", node); return; }