[3/3] kbuild: clean up *.dtb and *.dtb.S patterns from top-level Makefile

Message ID 1509377627-11362-4-git-send-email-yamada.masahiro@socionext.com
State New
Headers show
Series
  • .gitignore / kbuild: of: ignore and clean *.dtb and *.dtb.S globally
Related show

Commit Message

Masahiro Yamada Oct. 30, 2017, 3:33 p.m.
We need to add "clean-files" in Makfiles to clean up DT blobs, but we
often miss to do so.

Since there are no source files that end with .dtb or .dtb.S, so we
can clean-up those files from the top-level Makefile.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Oct. 30, 2017, 3:53 p.m. | #1
On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> We need to add "clean-files" in Makfiles to clean up DT blobs, but we

> often miss to do so.

>

> Since there are no source files that end with .dtb or .dtb.S, so we

> can clean-up those files from the top-level Makefile.

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

>

>  Makefile | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/Makefile b/Makefile

> index 63a4c0e..c577c63 100644

> --- a/Makefile

> +++ b/Makefile

> @@ -1544,7 +1544,7 @@ clean: $(clean-dirs)

>         $(call cmd,rmfiles)

>         @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \

>                 \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \

> -               -o -name '*.ko.*' \

> +               -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \


With this we can remove all the occurrences in the kernel:

$ git grep 'clean.*dtb'

Otherwise, the series looks good to me. I'm happy to apply it if the
kbuild folks don't.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Masahiro Yamada Oct. 30, 2017, 4:32 p.m. | #2
Hi Rob,

2017-10-31 0:53 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
> On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada

> <yamada.masahiro@socionext.com> wrote:

>> We need to add "clean-files" in Makfiles to clean up DT blobs, but we

>> often miss to do so.

>>

>> Since there are no source files that end with .dtb or .dtb.S, so we

>> can clean-up those files from the top-level Makefile.

>>

>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

>> ---

>>

>>  Makefile | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/Makefile b/Makefile

>> index 63a4c0e..c577c63 100644

>> --- a/Makefile

>> +++ b/Makefile

>> @@ -1544,7 +1544,7 @@ clean: $(clean-dirs)

>>         $(call cmd,rmfiles)

>>         @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \

>>                 \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \

>> -               -o -name '*.ko.*' \

>> +               -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \

>

> With this we can remove all the occurrences in the kernel:

>

> $ git grep 'clean.*dtb'

>

> Otherwise, the series looks good to me. I'm happy to apply it if the

> kbuild folks don't.

>

> Rob


Yes, please.  Thanks!




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Nov. 1, 2017, 9:45 p.m. | #3
On Tue, Oct 31, 2017 at 01:32:15AM +0900, Masahiro Yamada wrote:
> Hi Rob,

> 

> 2017-10-31 0:53 GMT+09:00 Rob Herring <robh+dt@kernel.org>:

> > On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada

> > <yamada.masahiro@socionext.com> wrote:

> >> We need to add "clean-files" in Makfiles to clean up DT blobs, but we

> >> often miss to do so.

> >>

> >> Since there are no source files that end with .dtb or .dtb.S, so we

> >> can clean-up those files from the top-level Makefile.

> >>

> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> >> ---

> >>

> >>  Makefile | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/Makefile b/Makefile

> >> index 63a4c0e..c577c63 100644

> >> --- a/Makefile

> >> +++ b/Makefile

> >> @@ -1544,7 +1544,7 @@ clean: $(clean-dirs)

> >>         $(call cmd,rmfiles)

> >>         @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \

> >>                 \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \

> >> -               -o -name '*.ko.*' \

> >> +               -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \

> >

> > With this we can remove all the occurrences in the kernel:

> >

> > $ git grep 'clean.*dtb'

> >

> > Otherwise, the series looks good to me. I'm happy to apply it if the

> > kbuild folks don't.

> >

> > Rob

> 

> Yes, please.  Thanks!


Can you post a follow-up patch removing all the clean-files lines.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Makefile b/Makefile
index 63a4c0e..c577c63 100644
--- a/Makefile
+++ b/Makefile
@@ -1544,7 +1544,7 @@  clean: $(clean-dirs)
 	$(call cmd,rmfiles)
 	@find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \
 		\( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \
-		-o -name '*.ko.*' \
+		-o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \
 		-o -name '*.dwo'  \
 		-o -name '*.su'  \
 		-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \