| Message ID | 1348745274-15936-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
> -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Thursday, September 27, 2012 4:58 PM > To: linux-kernel@vger.kernel.org > Cc: R, Durgadoss; Zhang, Rui; sachin.kamat@linaro.org; patches@linaro.org > Subject: [PATCH 1/2] thermal: fair_share: Add missing static storage class > specifiers > > Fixes the following sparse warnings: > drivers/thermal/fair_share.c:80:5: warning: > symbol 'fair_share_throttle' was not declared. Should it be static? > drivers/thermal/fair_share.c:111:25: warning: > symbol 'thermal_gov_fair_share' was not declared. Should it be static? > Looks fine. Acked-by: Durgadoss R <Durgadoss.r@intel.com> Thanks, Durga > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/thermal/fair_share.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c > index 5d3a7a3..792479f 100644 > --- a/drivers/thermal/fair_share.c > +++ b/drivers/thermal/fair_share.c > @@ -77,7 +77,7 @@ static long get_target_state(struct > thermal_zone_device *tz, > * (Heavily assumes the trip points are in ascending order) > * new_state of cooling device = P3 * P2 * P1 > */ > -int fair_share_throttle(struct thermal_zone_device *tz, int trip) > +static int fair_share_throttle(struct thermal_zone_device *tz, int trip) > { > const struct thermal_zone_params *tzp; > struct thermal_cooling_device *cdev; > @@ -108,7 +108,7 @@ int fair_share_throttle(struct thermal_zone_device > *tz, int trip) > return 0; > } > > -struct thermal_governor thermal_gov_fair_share = { > +static struct thermal_governor thermal_gov_fair_share = { > .name = "fair_share", > .throttle = fair_share_throttle, > .owner = THIS_MODULE, > -- > 1.7.4.1
diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c index 5d3a7a3..792479f 100644 --- a/drivers/thermal/fair_share.c +++ b/drivers/thermal/fair_share.c @@ -77,7 +77,7 @@ static long get_target_state(struct thermal_zone_device *tz, * (Heavily assumes the trip points are in ascending order) * new_state of cooling device = P3 * P2 * P1 */ -int fair_share_throttle(struct thermal_zone_device *tz, int trip) +static int fair_share_throttle(struct thermal_zone_device *tz, int trip) { const struct thermal_zone_params *tzp; struct thermal_cooling_device *cdev; @@ -108,7 +108,7 @@ int fair_share_throttle(struct thermal_zone_device *tz, int trip) return 0; } -struct thermal_governor thermal_gov_fair_share = { +static struct thermal_governor thermal_gov_fair_share = { .name = "fair_share", .throttle = fair_share_throttle, .owner = THIS_MODULE,
Fixes the following sparse warnings: drivers/thermal/fair_share.c:80:5: warning: symbol 'fair_share_throttle' was not declared. Should it be static? drivers/thermal/fair_share.c:111:25: warning: symbol 'thermal_gov_fair_share' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/thermal/fair_share.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)